Bug 2032554 - [RFE:EPEL9] EPEL9 branch for pre-commit
Summary: [RFE:EPEL9] EPEL9 branch for pre-commit
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: pre-commit
Version: epel9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Ben Beasley
QA Contact:
URL:
Whiteboard:
: 2152746 (view as bug list)
Depends On: 2032643 2032644 2032645 2134200
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-12-14 17:14 UTC by Pat Riehecky
Modified: 2023-08-03 01:52 UTC (History)
7 users (show)

Fixed In Version: pre-commit-3.3.3-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-03 01:52:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Pat Riehecky 2021-12-14 17:14:45 UTC
Description of problem:

Can pre-commit be branched for EPEL9

Version-Release number of selected component (if applicable): current fedora version


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Miro Hrončok 2021-12-14 18:52:48 UTC
I myself am not interested in this endeavor.

Comment 2 Pat Riehecky 2022-01-28 20:02:39 UTC
Will you be able to branch and build pre-commit in epel9?

Comment 3 Ben Beasley 2022-05-16 13:16:20 UTC
Ignoring the question for now of whether anyone is willing to maintain this, there are still some dependency issues blocking an EPEL9 backport.

- One can drop the BuildRequires on luarocks and skip any tests that require it, since this is only for Lua support.

- One can drop the BuildRequires on rubypick and skip any tests that require it, since this is only for Ruby support.

- One can drop the BuildRequires on python3dist(nodeenv) >= 0.11.1 and skip any tests that require it, since this is only for NodeJS support.

- One can patch out the BuildRequires on python3dist(re-assert) and skip any tests that require it, since it is used only for tests, and most of the tests don’t need it.

What’s left are the following truly mandatory dependencies:

> No matching package to install: 'python3dist(cfgv) >= 2'
(bug 2032645)
> No matching package to install: 'python3dist(identify) >= 1'
(bug 2032643)

Comment 4 Miro Hrončok 2022-12-12 22:47:19 UTC
*** Bug 2152746 has been marked as a duplicate of this bug. ***

Comment 5 Petr Šplíchal 2023-04-11 07:15:03 UTC
> What’s left are the following truly mandatory dependencies:
> 
> > No matching package to install: 'python3dist(cfgv) >= 2'
> (bug 2032645)
> > No matching package to install: 'python3dist(identify) >= 1'
> (bug 2032643)

Both above-mentioned dependencies should now be in stable repos.

Comment 6 Ben Beasley 2023-04-11 12:55:23 UTC
(In reply to Petr Šplíchal from comment #5)
> > What’s left are the following truly mandatory dependencies:
> > 
> > > No matching package to install: 'python3dist(cfgv) >= 2'
> > (bug 2032645)
> > > No matching package to install: 'python3dist(identify) >= 1'
> > (bug 2032643)
> 
> Both above-mentioned dependencies should now be in stable repos.

Thanks. I guess I missed in the previous analysis that nodeenv>=0.11.1 is required at install time. I suppose one could patch it out, thereby breaking node support, but let me see if I can help the maintainer patch out the deprecated python-mock dependency and get it into EPEL9 instead.

Comment 7 Ben Beasley 2023-04-11 14:33:44 UTC
I have offered a PR to update python-nodeenv to the current version: https://src.fedoraproject.org/rpms/python-nodeenv/pull-request/2

It removes the dependency on the deprecated python-mock package; if merged, python-nodeenv can be branched for EPEL9 without further changes.

If python-nodeenv is branched for EPEL9, the current pre-commit spec file from Rawhide can also be branched for EPEL9 without further changes. (All of the dependencies that I said would have to be patched out are now available, and the tests pass in a local mock build.)

Comment 8 Petr Šplíchal 2023-04-17 11:35:07 UTC
Ben, thank you very much for moving this forward!

Comment 9 Petr Šplíchal 2023-07-24 13:22:00 UTC
Nice, python-nodeenv for el9 is now in the stable repo:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-901fc40f3f

Comment 10 Ben Beasley 2023-07-24 13:50:37 UTC
It looks like the Rawhide spec file still works for EPEL9. I’m going to go ahead and request the branch.

Comment 11 Fedora Update System 2023-07-24 14:04:31 UTC
FEDORA-EPEL-2023-6ab9066c39 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6ab9066c39

Comment 12 Fedora Update System 2023-07-25 17:43:14 UTC
FEDORA-EPEL-2023-6ab9066c39 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6ab9066c39

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2023-07-26 00:43:24 UTC
FEDORA-EPEL-2023-6ab9066c39 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-6ab9066c39

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-08-03 01:52:51 UTC
FEDORA-EPEL-2023-6ab9066c39 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.