Bug 205306 (perl-SUPER)

Summary:	Review Request: perl-SUPER - Control superclass method dispatch
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	jwboyer: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/SUPER/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-09-07 23:10:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	205304
Bug Blocks:	163779, 205318

Description Chris Weyl 2006-09-05 22:19:19 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-SUPER-1.14-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-SUPER.spec

Description:
When subclassing a class, you occasionally want to dispatch control to the
superclass -- at least conditionally and temporarily. The Perl syntax for
calling your superclass is ugly and unwieldy:

Comment 1 Patrice Dumas 2006-09-07 07:36:14 UTC

The description ends with a :, this is certainly wrong...

perl(DB) should certainly filtered out.

It may be relevant to
Requires: perl(DB) perl(UNIVERSAL) 
even if they are in perl core, maybe with a explanatory comment. 

Otherwise
* rpmlint ignorable:
W: perl-SUPER strange-permission filter-provides.sh 0755

* package named according to guidelines
* free software, without licence files included
* meets packaging guidelines
* spec legible
* source match upstream
591389c353df308ee9e70d38f0e3570b  SUPER-1.14.tar.gz
X insane provides
Provides: perl(DB) perl(SUPER) = 1.14
* %files right

Comment 2 Chris Weyl 2006-09-07 20:08:20 UTC

Updated:

SRPM URL: http://home.comcast.net/~ckweyl/perl-SUPER-1.14-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-SUPER.spec

I'm not explicitly requiring perl(DB) perl(UNIVERSAL) right now as a) they don't
look to be required, and b) in any case they're in core, so I can quash this
question on the ground it's moot anyways ;)

Comment 3 Patrice Dumas 2006-09-07 20:25:19 UTC

The provides are right now, but the description is still
weird...

Comment 4 Chris Weyl 2006-09-07 20:54:44 UTC

That's what I get for being too literal and not reading the text I'm fixing. 
I'll update to:

"When subclassing a class, you occasionally want to dispatch control to the
superclass -- at least conditionally and temporarily.   This module provides
an easier, cleaner way for class methods to access their ancestor's
implementation."

Comment 5 Chris Weyl 2006-09-07 20:56:39 UTC

Updated:

SRPM URL: http://home.comcast.net/~ckweyl/perl-SUPER-1.14-3.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-SUPER.spec

Comment 6 Patrice Dumas 2006-09-07 21:45:26 UTC

APPROVED

Comment 7 Chris Weyl 2006-09-07 23:10:36 UTC

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+Request branching 
+Close bug

Thanks for the review! :)

Comment 8 Chris Weyl 2007-04-19 20:42:58 UTC

Please branch for EL-4, EL-5.