Bug 205318 (perl-Class-MOP) - Review Request: perl-Class-MOP - Class::MOP Perl module
Summary: Review Request: perl-Class-MOP - Class::MOP Perl module
Keywords:
Status: CLOSED NEXTRELEASE
Alias: perl-Class-MOP
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Package Reviews List
URL: http://search.cpan.org/dist/Class-MOP/
Whiteboard:
Depends On: perl-Sub-Name perl-SUPER perl-Class-C3
Blocks: FE-ACCEPT perl-Moose
TreeView+ depends on / blocked
 
Reported: 2006-09-05 23:39 UTC by Chris Weyl
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-07 23:38:49 UTC
Type: ---
Embargoed:
jwboyer: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2006-09-05 23:39:15 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Class-MOP-0.34-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Class-MOP.spec

Description:
This module is an attempt to create a meta object protocol for the Perl 5
object system. It makes no attempt to change the behavior or characteristics
of the Perl 5 object system, only to create a protocol for its manipulation
and introspection.

That said, it does attempt to create the tools for building a rich set of
extensions to the Perl 5 object system. Every attempt has been made for these
tools to keep to the spirit of the Perl 5 object system that we all know and
love.

Comment 1 Patrice Dumas 2006-09-07 22:13:05 UTC
Blocker: Test::Pod::Coverage and Test::Pod BR are missing.

Otherwise

* rpmlint is silent
* package named according to guidelines
* free software, without licence files included
* meets packaging guidelines
* spec legible
* source match upstream
88ae60fc9fe161598739f3de59d6932e  Class-MOP-0.34.tar.gz
* sane provides
Provides: perl(Class::MOP) = 0.34 perl(Class::MOP::Attribute) = 0.12
perl(Class::MOP::Attribute::Accessor) = 0.01 perl(Class::MOP::Class) = 0.19
perl(Class::MOP::Class::Immutable) = 0.02 perl(Class::MOP::Instance) = 0.03
perl(Class::MOP::Method) = 0.03 perl(Class::MOP::Method::Wrapped) = 0.01
perl(Class::MOP::Module) = 0.02 perl(Class::MOP::Object) = 0.02
perl(Class::MOP::Package) = 0.04 perl(metaclass) = 0.03
* %files right



Comment 3 Patrice Dumas 2006-09-07 23:32:15 UTC
APPROVED

Comment 4 Chris Weyl 2006-09-07 23:38:49 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+Request branching (FC-5)
+Close bug

Thanks for the review! :)

Comment 5 Ville Skyttä 2006-09-08 05:52:58 UTC
BTW the Summary (Class::MOP Perl module) is pretty much useless.

Comment 6 Chris Weyl 2007-04-19 20:44:54 UTC
Please branch for EL-4, EL-5.


Note You need to log in before you can comment on or make changes to this bug.