Bug 2233179

Summary: Review Request: golang-modernc-parser - Collection of Go parsers
Product: [Fedora] Fedora Reporter: W. Michael Petullo <mike>
Component: Package ReviewAssignee: Robert-André Mauchin 🐧 <eclipseo>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: eclipseo, package-review
Target Milestone: ---Flags: eclipseo: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-08-26 12:28:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2233178    
Bug Blocks: 2231928, 2233181    
Attachments:
Description Flags
The .spec file difference from Copr build 6328150 to 6338974 none

Description W. Michael Petullo 2023-08-21 16:15:43 UTC 
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-parser.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-parser-1.0.8-1.fc38.src.rpm
Description: Collection of Go parsers
Fedora Account System Username: mikep
Comment 1 Robert-André Mauchin 🐧 2023-08-23 17:54:09 UTC 
i don't see any cmd/ in yacc, remove all this:


%build
for cmd in yacc; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done


install -m 0755 -vd                     %{buildroot}%{_bindir}
install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/


%files
%license LICENSE
%doc README.md nquads-AUTHORS nquads-CONTRIBUTORS yacc-AUTHORS yacc-CONTRIBUTORS
%{_bindir}/*


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines


Please fix the above problem.
Comment 2 W. Michael Petullo 2023-08-23 20:23:59 UTC 
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-parser.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-parser-1.0.8-1.fc38.src.rpm

- Remove bin stuff
Comment 3 Fedora Review Service 2023-08-23 20:27:40 UTC 
Created attachment 1984892 [details]
The .spec file difference from Copr build 6328150 to 6338974
Comment 4 Robert-André Mauchin 🐧 2023-08-26 11:46:57 UTC 
No binaries, no need for this package:


%files
%license LICENSE
%doc README.md nquads-AUTHORS nquads-CONTRIBUTORS yacc-AUTHORS yacc-CONTRIBUTORS


You can remove this before import please.

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version
Comment 5 Fedora Admin user for bugzilla script actions 2023-08-26 12:15:15 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-parser
Comment 6 Fedora Update System 2023-08-26 12:26:36 UTC 
FEDORA-2023-bb8515843d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bb8515843d
Comment 7 Fedora Update System 2023-08-26 12:28:35 UTC 
FEDORA-2023-bb8515843d has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.