Bug 2233181 - Review Request: golang-modernc-scannertest - Provides helpers for automated testing of scanners/lexers/tokenizers
Summary: Review Request: golang-modernc-scannertest - Provides helpers for automated t...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2233179
Blocks: 2231928
TreeView+ depends on / blocked
 
Reported: 2023-08-21 16:18 UTC by W. Michael Petullo
Modified: 2023-08-27 14:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-27 14:19:57 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6328175 to 6345576 (512 bytes, patch)
2023-08-26 12:00 UTC, Fedora Review Service
no flags Details | Diff

Description W. Michael Petullo 2023-08-21 16:18:16 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-scannertest.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-scannertest-1.0.2-1.fc38.src.rpm
Description: Provides helpers for automated testing of scanners/lexers/tokenizers
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-26 11:45:15 UTC
 - Summary is too long:

Summary:        Provides helpers for automated testing of scanners/lexers/tokenizers

 - The license has a MIT Clause too:

License:        BSD-3-Clause AND MIT

- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors

Comment 2 W. Michael Petullo 2023-08-26 11:55:35 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-scannertest.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-scannertest-1.0.2-1.fc38.src.rpm

- Shorten summary
- Fix license

Comment 3 Fedora Review Service 2023-08-26 12:00:57 UTC
Created attachment 1985396 [details]
The .spec file difference from Copr build 6328175 to 6345576

Comment 4 Robert-André Mauchin 🐧 2023-08-26 12:54:09 UTC
- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 5 Fedora Admin user for bugzilla script actions 2023-08-27 14:08:04 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-scannertest

Comment 6 Fedora Update System 2023-08-27 14:18:08 UTC
FEDORA-2023-170cd8f572 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-170cd8f572

Comment 7 Fedora Update System 2023-08-27 14:19:57 UTC
FEDORA-2023-170cd8f572 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.