Bug 2233179 - Review Request: golang-modernc-parser - Collection of Go parsers
Summary: Review Request: golang-modernc-parser - Collection of Go parsers
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2233178
Blocks: 2231928 2233181
TreeView+ depends on / blocked
 
Reported: 2023-08-21 16:15 UTC by W. Michael Petullo
Modified: 2023-08-26 12:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-08-26 12:28:35 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 6328150 to 6338974 (633 bytes, patch)
2023-08-23 20:27 UTC, Fedora Review Service
no flags Details | Diff

Description W. Michael Petullo 2023-08-21 16:15:43 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-modernc-parser.spec
SRPM URL: https://www.flyn.org/SRPMS/golang-modernc-parser-1.0.8-1.fc38.src.rpm
Description: Collection of Go parsers
Fedora Account System Username: mikep

Comment 1 Robert-André Mauchin 🐧 2023-08-23 17:54:09 UTC
i don't see any cmd/ in yacc, remove all this:


%build
for cmd in yacc; do
  %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
done


install -m 0755 -vd                     %{buildroot}%{_bindir}
install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/


%files
%license LICENSE
%doc README.md nquads-AUTHORS nquads-CONTRIBUTORS yacc-AUTHORS yacc-CONTRIBUTORS
%{_bindir}/*


- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines


Please fix the above problem.

Comment 3 Fedora Review Service 2023-08-23 20:27:40 UTC
Created attachment 1984892 [details]
The .spec file difference from Copr build 6328150 to 6338974

Comment 4 Robert-André Mauchin 🐧 2023-08-26 11:46:57 UTC
No binaries, no need for this package:


%files
%license LICENSE
%doc README.md nquads-AUTHORS nquads-CONTRIBUTORS yacc-AUTHORS yacc-CONTRIBUTORS


You can remove this before import please.

- License ok
- Latest version packaged
- Builds in mock
- Checks pass
- No rpmlint errors
- Conforms to Go Packaging Guidelines

Package approved.

Please:
 - add commit rights to go-sig after requesting the repo
 - add the package to Koschei in the go-sig group on all branches you are building
 - add the package to release-monitoring.org even if it does not release version

Comment 5 Fedora Admin user for bugzilla script actions 2023-08-26 12:15:15 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-modernc-parser

Comment 6 Fedora Update System 2023-08-26 12:26:36 UTC
FEDORA-2023-bb8515843d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-bb8515843d

Comment 7 Fedora Update System 2023-08-26 12:28:35 UTC
FEDORA-2023-bb8515843d has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.