Bug 2256304
| Summary: | Review Request: golang-github-apex-logs - Apex Logs client for Go | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | W. Michael Petullo <mike> |
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mikel, package-review |
| Target Milestone: | --- | Flags: | mikel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-02-01 00:57:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2256312 | ||
| Bug Blocks: | 2256303, 2256306 | ||
|
Description
W. Michael Petullo
2023-12-31 01:30:10 UTC
Spec URL: https://www.flyn.org/SRPMS/golang-github-apex-logs.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-apex-logs-0.9.23-1.fc39.src.rpm Rebuild with go2rpm 1.10.0. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840028 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256304-golang-github-apex-logs/fedora-rawhide-x86_64/06840028-golang-github-apex-logs/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/6840057 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256304-golang-github-apex-logs/fedora-rawhide-x86_64/06840057-golang-github-apex-logs/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spect is correct, but change this before pushing to pagure.
> %check
> # Check uses network.
> %gocheck -d .
Replace with:
%check
for test in "TestService_GetProjects" "TestHTTP" \
; do
awk -i inplace '/^func.*'"$test"'\(/ { print; print "\tt.Skip(\"disabled failing test\")"; next}1' $(grep -rl $test)
done
%gocheck
I am not going to go through the whole fedora-review template, as this package uses go2rpm.
- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
Spec URL: https://www.flyn.org/SRPMS/golang-github-apex-logs.spec SRPM URL: https://www.flyn.org/SRPMS/golang-github-apex-logs-0.9.23-1.fc39.src.rpm Adjust check as indicated in comment #4. |