Bug 2295801
| Summary: | Review Request: rust-pnet_macros - Automatic bit manipulation for binary data formats | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adrián Moreno <amorenoz> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | atenart, decathorpe, ferferna, package-review, pvalerio |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/pnet_macros | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-11-25 15:20:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2295802 | ||
| Bug Blocks: | 2295799 | ||
|
Description
Adrián Moreno
2024-07-04 13:58:25 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7707890 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295801-rust-pnet_macros/fedora-rawhide-x86_64/07707890-rust-pnet_macros/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The dependent, rust-pnet_packet (https://bugzilla.redhat.com/show_bug.cgi?id=2295799), is now part of Rawhide. Re-triggering the build: [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/8183567 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295801-rust-pnet_macros/fedora-rawhide-x86_64/08183567-rust-pnet_macros/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. (In reply to Adrián Moreno from comment #2) > The dependent, rust-pnet_packet > (https://bugzilla.redhat.com/show_bug.cgi?id=2295799), is now part of > Rawhide. Sorry, wrong package, I meant: rust-pnet_macros_support (https://bugzilla.redhat.com/show_bug.cgi?id=2295802). @decathorpe @ferferna Is there something that needs to be done on my side to get this package ready for review? Thanks There is nothing you need to do other than be patient. It looks like the package is ready for review since all dependencies are available now - it's just that nobody has started doing the actual review yet. The package looks good to me! === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged: 0.34 vs. 0.35, but 0.34 matches other related crates that are already packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pnet_macros FEDORA-2024-181a8cdda6 (rust-pnet_macros-0.34.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-181a8cdda6 FEDORA-2024-181a8cdda6 (rust-pnet_macros-0.34.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |