Bug 2295801 - Review Request: rust-pnet_macros - Automatic bit manipulation for binary data formats
Summary: Review Request: rust-pnet_macros - Automatic bit manipulation for binary data...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/pnet_macros
Whiteboard:
Depends On: 2295802
Blocks: 2295799
TreeView+ depends on / blocked
 
Reported: 2024-07-04 13:58 UTC by Adrián Moreno
Modified: 2024-11-25 15:20 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-11-25 15:20:30 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Adrián Moreno 2024-07-04 13:58:25 UTC
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-pnet_macros.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/%40retis/playground/fedora-rawhide-x86_64/07671872-rust-pnet_macros/rust-pnet_macros-0.34.0-1.fc41.src.rpm
Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671872/

Description:

Automatic bit manipulation for binary data formats. It is part of the libpnet project that provides cross-platform API for low level networking in Rust.

Fedora Account System Usernames: atenart, pvaler, amorenoz

Notes:
Other components of the libpnet project, such as rust-pnet_datalink (https://packages.fedoraproject.org/pkgs/rust-pnet_datalink/) are already packaged in Fedora.

Needed by rust-pnet_packet (https://bugzilla.redhat.com/show_bug.cgi?id=2295799).

Comment 1 Fedora Review Service 2024-07-04 14:13:48 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7707890
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295801-rust-pnet_macros/fedora-rawhide-x86_64/07707890-rust-pnet_macros/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Adrián Moreno 2024-10-28 14:10:16 UTC
The dependent, rust-pnet_packet (https://bugzilla.redhat.com/show_bug.cgi?id=2295799), is now part of Rawhide. Re-triggering the build: [fedora-review-service-build]

Comment 3 Fedora Review Service 2024-10-28 14:18:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8183567
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295801-rust-pnet_macros/fedora-rawhide-x86_64/08183567-rust-pnet_macros/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Adrián Moreno 2024-10-29 10:05:53 UTC
(In reply to Adrián Moreno from comment #2)
> The dependent, rust-pnet_packet
> (https://bugzilla.redhat.com/show_bug.cgi?id=2295799), is now part of
> Rawhide. 

Sorry, wrong package, I meant: rust-pnet_macros_support (https://bugzilla.redhat.com/show_bug.cgi?id=2295802).

Comment 5 Adrián Moreno 2024-11-05 10:15:54 UTC
@decathorpe
@ferferna 
Is there something that needs to be done on my side to get this package ready for review? Thanks

Comment 6 Fabio Valentini 2024-11-05 20:19:45 UTC
There is nothing you need to do other than be patient.
It looks like the package is ready for review since all dependencies are available now - it's just that nobody has started doing the actual review yet.

Comment 7 Fabio Valentini 2024-11-07 16:46:13 UTC
The package looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
🫤 latest version of the crate is packaged:
   0.34 vs. 0.35, but 0.34 matches other related crates that are already packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version (*NOT* pre-release) filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 8 Fedora Admin user for bugzilla script actions 2024-11-25 14:21:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pnet_macros

Comment 9 Fedora Update System 2024-11-25 15:16:24 UTC
FEDORA-2024-181a8cdda6 (rust-pnet_macros-0.34.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-181a8cdda6

Comment 10 Fedora Update System 2024-11-25 15:20:30 UTC
FEDORA-2024-181a8cdda6 (rust-pnet_macros-0.34.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.