Bug 2295802 - Review Request: rust-pnet_macros_support - Support library for libpnet_macros
Summary: Review Request: rust-pnet_macros_support - Support library for libpnet_macros
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/pnet_macros_...
Whiteboard:
Depends On:
Blocks: 2295799 2295801
TreeView+ depends on / blocked
 
Reported: 2024-07-04 14:02 UTC by Adrián Moreno
Modified: 2024-10-24 19:10 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-10-24 19:10:16 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Adrián Moreno 2024-07-04 14:02:12 UTC
Spec URL: https://raw.githubusercontent.com/retis-org/copr-playground/main/rust-pnet_macros_support.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/%40retis/playground/fedora-rawhide-x86_64/07671853-rust-pnet_macros_support/rust-pnet_macros_support-0.34.0-1.fc41.src.rpm
Build: https://copr.fedorainfracloud.org/coprs/g/retis/playground/build/7671853/

Description:

Support library for libpnet_macros. It is part of the libpnet project that provides cross-platform API for low level networking in Rust.

Fedora Account System Usernames: atenart, pvaler, amorenoz

Notes:
Other components of the libpnet project, such as rust-pnet_datalink (https://packages.fedoraproject.org/pkgs/rust-pnet_datalink/) are already packaged in Fedora.

Needed by rust-pnet_macros (https://bugzilla.redhat.com/show_bug.cgi?id=2295801)

Comment 1 Fedora Review Service 2024-07-04 14:30:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7707893
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295802-rust-pnet_macros_support/fedora-rawhide-x86_64/07707893-rust-pnet_macros_support/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-07-14 15:47:17 UTC
Please provide URLs to raw files, not HTML pages. Otherwise tooling will not be able to parse this ticket.

Comment 3 Fabio Valentini 2024-07-22 10:06:48 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2024-07-22 22:13:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7773651
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2295802-rust-pnet_macros_support/fedora-rawhide-x86_64/07773651-rust-pnet_macros_support/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2024-08-04 17:49:11 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are no tests)
🫤 latest version of the crate is packaged (0.34.0 vs. 0.35.0, but 0.34.0 matches existing pnet_* packages in Fedora, so this is OK)
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 6 Fernando F. Mancera 2024-10-15 14:42:54 UTC
I have went through the whole checklist. Package approved.

Comment 7 Fabio Valentini 2024-10-15 19:02:10 UTC
The package *was* already approved, and I suspect it's now in a state where the bot won't let you request the repo? :D

Comment 8 Fernando F. Mancera 2024-10-16 06:44:31 UTC
The opposite I think, the bot was not allowing to create the repo because the review was too old. I went through the checklist again to make sure nothing changed. I think now all should be fine.

Comment 9 Fabio Valentini 2024-10-16 19:50:47 UTC
If the review was too old, then *I* would need to refresh the fedora-review+ flag.
The account setting the fedora-review+ flag must match the bug assignee, otherwise the processing will complain about an invalid bug state.

Comment 10 Fernando F. Mancera 2024-10-16 20:04:13 UTC
Ah thank you for explaining. Noted!. Sorry for the inconvenience.

Comment 11 Fedora Admin user for bugzilla script actions 2024-10-24 12:13:26 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pnet_macros_support

Comment 12 Fedora Update System 2024-10-24 18:39:51 UTC
FEDORA-2024-7dcdf940dc (rust-pnet_macros_support-0.34.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7dcdf940dc

Comment 13 Fedora Update System 2024-10-24 19:10:16 UTC
FEDORA-2024-7dcdf940dc (rust-pnet_macros_support-0.34.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.