Bug 232619

Summary: Review Request: perl-XML-SAX-Writer - SAX2 Writer
Product: [Fedora] Fedora Reporter: Andreas Thienemann <andreas>
Component: Package ReviewAssignee: Ville Skyttä <ville.skytta>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideFlags: ville.skytta: fedora-review+
petersen: fedora-cvs+
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-03-23 10:18:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 232618    
Bug Blocks: 232620    

Description Andreas Thienemann 2007-03-16 13:26:13 UTC
Spec URL: http://home.bawue.de/~ixs/perl-XML-SAX-Writer/perl-XML-SAX-Writer.spec
SRPM URL: http://home.bawue.de/~ixs/perl-XML-SAX-Writer/perl-XML-SAX-Writer-0.50-1.src.rpm
Description:

A new XML Writer to match the SAX2 effort.

Comment 1 Ville Skyttä 2007-03-17 20:13:03 UTC
* These explicit dependencies are dupes of (unversioned) autogenerated ones,
just remove them?  The versions seem to come from Makefile.PL but upstream has
chose to not require any particular version of things at runtime.
perl(Text::Iconv) >= 1.2
perl(XML::Filter::BufferText) >= 1.00
perl(XML::NamespaceSupport) >= 1.00
perl(XML::SAX::Exception) >= 1.01

* Doing the iconv-to-UTF-8 stuff for the man page only doesn't help perldoc. 
Doing it for Writer.pm in %prep would work for both man and perldoc.

Comment 2 Andreas Thienemann 2007-03-17 22:24:52 UTC
http://home.bawue.de/~ixs/perl-XML-SAX-Writer/perl-XML-SAX-Writer-0.50-2.src.rpm

new spec, fixing these issues.

Comment 3 Ville Skyttä 2007-03-18 10:35:14 UTC
Approved

Comment 4 Andreas Thienemann 2007-03-18 11:53:30 UTC
New Package CVS Request
=======================
Package Name: perl-XML-SAX-Writer
Short Description: SAX2 Writer
Owners: andreas@bawue.net
Branches: FC-5, FC-6, devel
InitialCC: fedora-perl-devel-list@redhat.com


Comment 5 Jens Petersen 2007-03-20 00:06:31 UTC
done

Comment 6 Andreas Thienemann 2007-03-23 10:18:20 UTC
Thanks for the review. Package has been built for FC-5, FC-6 and rawhide.