Bug 236393
| Summary: | face browser shows no faces | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrew Overholt <overholt> | ||||
| Component: | control-center | Assignee: | Control Center Maintainer <control-center-maint> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | a.kurtz, bnocera, davidz, eharney, rstrode | ||||
| Target Milestone: | --- | Keywords: | EasyFix, Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 2.18.0-18.fc7 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-05-22 19:43:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 150226 | ||||||
| Attachments: |
|
||||||
|
Description
Andrew Overholt
2007-04-13 15:51:32 UTC
The face needs to have permission 755 IIRC - does that work? Everything in /usr/share/pixmaps/faces is 755 and it's one of those that I'm picking. Setting a face involves copy that file to ~/.face - what's the permission there? My guess is that "About Me" gets it wrong there... Yeah, that's what the problem was. If I chmod 755 ~/.face it works. OK, reassigning to control-center then - the "About Me" dialog needs to set the correct mode on ~/.face. Looking at gdm_get_facefile_from_home(), ~/.face will also not work on a) automounted homedirs b) nfs homedirs It would probably be better to switch to using GlobalFaceDir. Of course, that adds complication to storing the face in the about-me capplet. Andrew, do you use a umask different from the default one? Do you remember what the permissions were on that file before you changed them? What were the permissions on your home directory as well? I installed this machine with the test2 live cd and haven't messed with the default umask. I think the permissions were rw-rw-r-- IIRC. My home directory is rwx------. If I remove ~/.face, will things go back to how they were before for us to check? I forgot that I didn't format my /home partition so it may have some wacky settings from the old installations. Could that be it? I really don't think I've changed umasks before, though. I could reproduce this on my laptop. In the log I see:
Apr 27 16:02:42 snoogens gdm[3369]: run_pictures: /home/hadess/.face is writable
by group.
In the code this is:
/* ... if group has write permission ... */
if G_UNLIKELY (perms < 1 && (statbuf.st_mode & S_IWGRP) == S_IWGRP) {
syslog (LOG_WARNING, _("%s: %s is writable by group."), caller, dir);
return FALSE;
}
(in daemon/filecheck.c)
this function is called from check_user_file(), itself called from
gdm_get_facefile_from_home() (both in gdmconfig.c)
So we need to make sure the file isn't writable by the group, or remove the
check from gdm. I did a chmod on my ~/.face to 755 and it works fine.
Created attachment 153629 [details]
control-center-2.18.0-set-face-perms.patch
Untested patch. Ray, could you test and apply?
Patch looks good to me. *** Bug 179828 has been marked as a duplicate of this bug. *** The latest version that got applied upstream should apply with a bit of fuzz: http://bugzilla.gnome.org/attachment.cgi?id=87277&action=view Fixed in control-center-2.18.0-15.fc7 *** Bug 240257 has been marked as a duplicate of this bug. *** not that i'm hit by this bug, but it looks like the fix is only included in the package, not actually applied. http://cvs.fedora.redhat.com/viewcvs/rpms/control-center/devel/control-center.spec?r1=1.248&r2=1.249 Applied and built now Thanks Sertaç for the notice. Really fixed in control-center-2.18.0-18.fc7 |