Bug 236393 - face browser shows no faces
face browser shows no faces
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: control-center (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Control Center Maintainer
David Lawrence
: EasyFix, Reopened
: 179828 240257 (view as bug list)
Depends On:
Blocks: FC7Blocker
  Show dependency treegraph
 
Reported: 2007-04-13 11:51 EDT by Andrew Overholt
Modified: 2007-11-30 17:12 EST (History)
5 users (show)

See Also:
Fixed In Version: 2.18.0-18.fc7
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-05-22 15:43:01 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
control-center-2.18.0-set-face-perms.patch (791 bytes, patch)
2007-04-27 11:29 EDT, Bastien Nocera
no flags Details | Diff


External Trackers
Tracker ID Priority Status Summary Last Updated
GNOME Desktop 433898 None None None Never

  None (edit)
Description Andrew Overholt 2007-04-13 11:51:32 EDT
If I set my face icon preference in the About Me app, it's not shown in gdm.  Is
this expected?  I'm just using a stock face icon from /usr/share/pixmaps/faces
(or wherever).

gdm-2.18.0-10.fc7.i386
Comment 1 David Zeuthen 2007-04-14 22:17:04 EDT
The face needs to have permission 755 IIRC - does that work?
Comment 2 Andrew Overholt 2007-04-14 23:51:57 EDT
Everything in /usr/share/pixmaps/faces is 755 and it's one of those that I'm
picking.
Comment 3 David Zeuthen 2007-04-14 23:55:22 EDT
Setting a face involves copy that file to ~/.face - what's the permission there?
My guess is that "About Me" gets it wrong there...
Comment 4 Andrew Overholt 2007-04-16 10:46:52 EDT
Yeah, that's what the problem was.  If I chmod 755 ~/.face it works.
Comment 5 David Zeuthen 2007-04-16 12:03:05 EDT
OK, reassigning to control-center then - the "About Me" dialog needs to set the
correct mode on ~/.face.
Comment 6 Matthias Clasen 2007-04-17 09:06:00 EDT
Looking at gdm_get_facefile_from_home(), ~/.face will also not work on

a) automounted homedirs
b) nfs homedirs

It would probably be better to switch to using GlobalFaceDir. Of course, that adds
complication to storing the face in the about-me capplet.
Comment 7 Bastien Nocera 2007-04-19 12:28:35 EDT
Andrew, do you use a umask different from the default one? Do you remember what
the permissions were on that file before you changed them?

What were the permissions on your home directory as well?
Comment 8 Andrew Overholt 2007-04-19 13:08:40 EDT
I installed this machine with the test2 live cd and haven't messed with the
default umask. I think the permissions were rw-rw-r-- IIRC.  My home directory
is rwx------.

If I remove ~/.face, will things go back to how they were before for us to check?
Comment 9 Andrew Overholt 2007-04-19 13:09:46 EDT
I forgot that I didn't format my /home partition so it may have some wacky
settings from the old installations.  Could that be it?  I really don't think
I've changed umasks before, though.
Comment 10 Bastien Nocera 2007-04-27 11:15:40 EDT
I could reproduce this on my laptop. In the log I see:
Apr 27 16:02:42 snoogens gdm[3369]: run_pictures: /home/hadess/.face is writable
by group.

In the code this is:
    /* ... if group has write permission ... */
    if G_UNLIKELY (perms < 1 && (statbuf.st_mode & S_IWGRP) == S_IWGRP) {
        syslog (LOG_WARNING, _("%s: %s is writable by group."), caller, dir);
        return FALSE;
    }
(in daemon/filecheck.c)

this function is called from check_user_file(), itself called from
gdm_get_facefile_from_home() (both in gdmconfig.c)

So we need to make sure the file isn't writable by the group, or remove the
check from gdm. I did a chmod on my ~/.face to 755 and it works fine.
Comment 11 Bastien Nocera 2007-04-27 11:29:05 EDT
Created attachment 153629 [details]
control-center-2.18.0-set-face-perms.patch

Untested patch. Ray, could you test and apply?
Comment 12 Matthias Clasen 2007-04-27 19:43:22 EDT
Patch looks good to me.
Comment 13 Bastien Nocera 2007-04-30 04:12:27 EDT
*** Bug 179828 has been marked as a duplicate of this bug. ***
Comment 14 Bastien Nocera 2007-04-30 13:54:11 EDT
The latest version that got applied upstream should apply with a bit of fuzz:
http://bugzilla.gnome.org/attachment.cgi?id=87277&action=view
Comment 15 Bastien Nocera 2007-05-01 05:47:26 EDT
Fixed in control-center-2.18.0-15.fc7
Comment 16 Bastien Nocera 2007-05-16 04:43:42 EDT
*** Bug 240257 has been marked as a duplicate of this bug. ***
Comment 17 Sertaç Ö. Yıldız 2007-05-22 11:40:26 EDT
not that i'm hit by this bug, but it looks like the fix is only included in the
package, not actually applied.

http://cvs.fedora.redhat.com/viewcvs/rpms/control-center/devel/control-center.spec?r1=1.248&r2=1.249
Comment 18 Jeremy Katz 2007-05-22 15:26:32 EDT
Applied and built now
Comment 19 Bastien Nocera 2007-05-22 15:43:01 EDT
Thanks Sertaç for the notice.
Really fixed in control-center-2.18.0-18.fc7

Note You need to log in before you can comment on or make changes to this bug.