Bug 2363933

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8994505
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363933-perl-dist-build/fedora-rawhide-x86_64/08994505-perl-Dist-Build/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires 
FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
FIX: Add build-require
     - perl(Config) - t/simple.t:4

$ rpm -qp --requires perl-Dist-Build-0.020-2.fc43.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(CPAN::Meta)
      1 perl(CPAN::Requirements::Dynamic) >= 0.002
      1 perl(Dist::Build::Core)
      1 perl(Dist::Build::Serializer)
      2 perl(Exporter) >= 5.57
      1 perl(ExtUtils::Builder::Action::Function)
      1 perl(ExtUtils::Builder::Compiler) >= 0.028
      1 perl(ExtUtils::Builder::Node)
      2 perl(ExtUtils::Builder::Planner) >= 0.016
      1 perl(ExtUtils::Builder::Planner::Extension)
      1 perl(ExtUtils::Builder::Serializer)
      1 perl(ExtUtils::Builder::Util)
      1 perl(ExtUtils::Config)
      1 perl(ExtUtils::Helpers) >= 0.007
      2 perl(ExtUtils::Helpers) >= 0.028
      1 perl(ExtUtils::Install)
      1 perl(ExtUtils::InstallPaths)
      1 perl(ExtUtils::Manifest)
      1 perl(File::Basename)
      1 perl(File::Copy)
      1 perl(File::Find)
      1 perl(File::Path)
      1 perl(File::ShareDir::Tiny)
      1 perl(File::Spec::Functions)
      2 perl(Getopt::Long) >= 2.36
      1 perl-libs
      2 perl(List::Util) >= 1.33
      1 perl(parent)
      1 perl(Parse::CPAN::Meta)
      1 perl(strict)
      1 perl(Text::ParseWords)
      1 perl(version)
      1 perl(warnings)
FIX: Please add run-requires:
      perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134
      perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17
      perl(Perl::OSType) - lib/Dist/Build.pm:93
      perl(Pod::Man) - lib/Dist/Build/Core.pm:309
      perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332

FIX: Please remove duplicit run-requires:
      perl(Exporter) >= 5.57
      perl(ExtUtils::Builder::Planner) >= 0.016
      perl(ExtUtils::Helpers) >= 0.028
      perl(Getopt::Long) >= 2.36
      perl(List::Util) >= 1.33

Otherwise binary requires are ok.

$ rpm -qp --provides perl-Dist-Build-0.020-2.fc43.noarch.rpm | sort | uniq -c
      1 perl(Dist::Build) = 0.020
      1 perl-Dist-Build = 0.020-2.fc43
      1 perl(Dist::Build::Core) = 0.020
      1 perl(Dist::Build::DynamicPrereqs) = 0.020
      1 perl(Dist::Build::Serializer) = 0.020
      1 perl(Dist::Build::ShareDir) = 0.020
      1 perl(Dist::Build::XS) = 0.020
      1 perl(Dist::Build::XS::Alien) = 0.020
      1 perl(Dist::Build::XS::Conf) = 0.020
      1 perl(Dist::Build::XS::Export) = 0.020
      1 perl(Dist::Build::XS::Import) = 0.020
      1 perl(Dist::Build::XS::WriteConstants) = 0.020
Binary provides are Ok.

$ rpmlint ./*
Rpmlint is ok

TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.

Resolution:
NOT Approved

(In reply to Jitka Plesnikova from comment #2)
> FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> FIX: Add build-require
>      - perl(Config) - t/simple.t:4
> FIX: Please add run-requires:
>       perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134
>       perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17
>       perl(Perl::OSType) - lib/Dist/Build.pm:93
>       perl(Pod::Man) - lib/Dist/Build/Core.pm:309
>       perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332
> FIX: Please remove duplicit run-requires:
>       perl(Exporter) >= 5.57
>       perl(ExtUtils::Builder::Planner) >= 0.016
>       perl(ExtUtils::Helpers) >= 0.028
>       perl(Getopt::Long) >= 2.36
>       perl(List::Util) >= 1.33
> TODO: Explicitly name packaged files in %{_mandir}/man* and
> %{perl_vendorlib} directories

I fixed all the above issues:

Spec URL: https://cra.fedorapeople.org/perl-Dist-Build/perl-Dist-Build.spec
SRPM URL: https://cra.fedorapeople.org/perl-Dist-Build/perl-Dist-Build-0.020-3.fc44.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9451102
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2363933-perl-dist-build/fedora-rawhide-x86_64/09451102-perl-Dist-Build/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

(In reply to Charles R. Anderson from comment #3)
> (In reply to Jitka Plesnikova from comment #2)
> > FIX: Add build-require 'coreutils' it is needed for %{_fixperms}
> > FIX: Add build-require
> >      - perl(Config) - t/simple.t:4
> > FIX: Please add run-requires:
> >       perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134
> >       perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17
> >       perl(Perl::OSType) - lib/Dist/Build.pm:93
> >       perl(Pod::Man) - lib/Dist/Build/Core.pm:309
> >       perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332
> > FIX: Please remove duplicit run-requires:
> >       perl(Exporter) >= 5.57
> >       perl(ExtUtils::Builder::Planner) >= 0.016
> >       perl(ExtUtils::Helpers) >= 0.028
> >       perl(Getopt::Long) >= 2.36
> >       perl(List::Util) >= 1.33
> > TODO: Explicitly name packaged files in %{_mandir}/man* and
> > %{perl_vendorlib} directories
> 
> I fixed all the above issues:

10a11
+ BuildRequires:  coreutils
17a19
+ BuildRequires:  perl(Config)
64a67
+ Requires:       perl(CPAN::Meta::Merge)
66d68
- Requires:       perl(Exporter) >= 5.57
68,71c70,72
- Requires:       perl(ExtUtils::Builder::Planner) >= 0.016
- Requires:       perl(ExtUtils::Helpers) >= 0.028
- Requires:       perl(Getopt::Long) >= 2.36
- Requires:       perl(List::Util) >= 1.33
---
+ Requires:       perl(Perl::OSType)
+ Requires:       perl(Pod::Man)
+ Requires:       perl(TAP::Harness::Env)
98,99c99,102
- %{perl_vendorlib}/*
- %{_mandir}/man3/*
---
+ %dir %{perl_vendorlib}/Dist
+ %{perl_vendorlib}/Dist/Build.pm
+ %{perl_vendorlib}/Dist/Build
+ %{_mandir}/man3/Dist::Build*

The changes look good.

Resolution:
Approved

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Dist-Build

FEDORA-2025-ed5838dceb (perl-Dist-Build-0.020-3.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-ed5838dceb

FEDORA-2025-c280d7fc69 (perl-Dist-Build-0.020-3.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-c280d7fc69

FEDORA-2025-05b2d10656 (perl-Dist-Build-0.020-3.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-05b2d10656

FEDORA-2025-bb6c925356 (perl-Dist-Build-0.020-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-bb6c925356

FEDORA-2025-bb6c925356 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-bb6c925356 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-bb6c925356

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-c280d7fc69 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c280d7fc69 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c280d7fc69

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-05b2d10656 has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-05b2d10656 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-05b2d10656

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2025-05b2d10656 (perl-Dist-Build-0.020-3.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-bb6c925356 (perl-Dist-Build-0.020-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2025-c280d7fc69 (perl-Dist-Build-0.020-3.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.