Bug 414211

Summary: Review Request: mfiler2 - Two pane file manager under UNIX console
Product: [Fedora] Fedora Reporter: Mamoru TASAKA <mtasaka>
Component: Package ReviewAssignee: Brian Pepple <bdpepple>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: bdpepple: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-12-10 18:04:13 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 414191, 414201    
Bug Blocks:    
Attachments:
Description Flags
mock build of mfiler2 on rawhide, i386 none

Description Mamoru TASAKA 2007-12-06 16:06:56 UTC
Spec URL: http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2.spec
SRPM URL: http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2-3.2.3-1.fc8.src.rpm
Description: 
Minnu's Filer2 is a two pane file manager under UNIX console.

This bug depends on oniguruma (bug 414191) and wkf (bug 414201)

Comment 1 Mamoru TASAKA 2007-12-06 16:09:06 UTC
Created attachment 279841 [details]
mock build of mfiler2 on rawhide, i386

As this package depends on two packages which are still under review,
currently koji scratch build cannot be done.

Mock build is successful on rawhide, i386.

Comment 2 Mamoru TASAKA 2007-12-08 04:28:29 UTC
Review request on oniguma and wkf finished.
Now mfiler2 builds on koji, dist-f9.

http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2.spec
http://mtasaka.fedorapeople.org/Review_request/mfiler2/mfiler2-3.2.3-2.fc8.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=282794

-------------------------------------------------
* Sat Dec  8 2007 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 3.2.3-2
- Add missing CFLAGS


Comment 3 Brian Pepple 2007-12-08 18:04:50 UTC
I'll try to review this later today for you.

Comment 4 Brian Pepple 2007-12-08 20:35:34 UTC
Good:
* Source URL is canonical
* Upstream source tarball verified
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* Buildroot has all required elements
* All paths begin with macros
* Files have appropriate permissions and owners
* Valid license tag
* Package builds. http://koji.fedoraproject.org/koji/taskinfo?taskID=282794
* Package requires ruby & ruby abi version.

rpmlint produces only the following warning which can be ignored:
mfiler2-mdnd.x86_64: W: no-documentation

+1 APPROVE

Comment 5 Mamoru TASAKA 2007-12-09 04:32:08 UTC
Thank you!

New Package CVS Request
=======================
Package Name:      mfiler2
Short Description: Two pane file manager under UNIX console
Owners:            mtasaka
Branches:          F-8 F-7
InitialCC: 
Cvsextras Commits: yes


Comment 6 Kevin Fenzi 2007-12-10 17:04:57 UTC
cvs done.

Comment 7 Mamoru TASAKA 2007-12-10 18:04:13 UTC
Rebuilt on dist-f9, closing
(Rebuild on F-8/7 is not done yet because BuildRequires packages
 are not in buildroot yet).

Thank you for your review!