Spec URL: http://mtasaka.fedorapeople.org/Review_request/wkf/wkf.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/wkf/wkf-1.3.11-1.fc8.src.rpm Description: WKF is a Japanese Kanji code converting filter. koji scratch build for dist-f8-updates-candidate is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=279217
* mock build went fine for devel but its log showed me /bin/mv: cannot stat `/var/tmp/wkf-1.3.11-1.fc8-root-kojibuilder/usr/bin/wkf': No such file or directory make: [install-prog] Error 1 (ignored) * source matches upstream * a48f7744d1fbbcdad45ce877cfc6e0f3 wkf-1.3.11.tar.bz2 * ldconfig scriptlets used. * rpmlint gave wkf-devel.i386: W: no-dependency-on wkf ==> which looks ok. * why %makeinstall used?
(In reply to comment #1) > * mock build went fine for devel but its log showed me > /bin/mv: cannot stat `/var/tmp/wkf-1.3.11-1.fc8-root-kojibuilder/usr/bin/wkf': > No such file or directory > make: [install-prog] Error 1 (ignored) Yes, this comes from the following lines in Makefile.in ------------------------------------------------------- 197 install-prog:: $(PROG) 198 -${MV} -f ${bindir}/${PROG} ${bindir}/${PROG}.old 199 ${INSTALL_PROGRAM} ${PROG} ${bindir} ------------------------------------------------------- It is harmless, however I can remove this if you want. > * why %makeinstall used? Because Makefile.in does not accept recent method like "DESTDIR=" (as shown above)...
Ok. I don't see those things are blockers. + Package wkf-1.3.11-1.fc9-> Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) wkf-libs = 1.3.11-1.fc9 Package wkf-libs-1.3.11-1.fc9 -> Provides: libwkf13.so.1 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) rtld(GNU_HASH) + Package wkf-devel-1.3.11-1.fc9 -> Requires: libwkf13.so.1 wkf-libs = 1.3.11-1.fc9 APPROVED.
Thank you! New Package CVS Request ======================= Package Name: wkf Short Description: Japanese Kanji code converting filter Owners: mtasaka Branches: F-8 F-7 InitialCC: Cvsextras Commits: yes
cvs done.
Rebuilt on all branches, requested on bodhi, closing. Thank you for your review!