Bug 433970

../../pan/general/string-view.h: In static member function 'static char*
pan::StringView::strchr(const char*, size_t, char)':
../../pan/general/string-view.h:48: error: 'memchr' was not declared in this scope
../../pan/general/string-view.h: In member function 'bool
pan::StringView::operator==(const char*) const':
../../pan/general/string-view.h:108: error: 'strlen' was not declared in this scope
../../pan/general/string-view.h: In member function 'bool
pan::StringView::operator!=(const char*) const':
../../pan/general/string-view.h:109: error: 'strlen' was not declared in this scope
../../pan/general/string-view.h: In member function 'int
pan::StringView::strncasecmp(const char*, unsigned int)':
../../pan/general/string-view.h:116: error: '::strncasecmp' has not been declared
../../pan/general/string-view.h:118: error: '::strncasecmp' has not been declared
../../pan/general/string-view.h: In member function 'char*
pan::StringView::strstr(const char*) const':
../../pan/general/string-view.h:138: error: '::strlen' has not been declared
../../pan/general/string-view.h: In member function 'void
pan::StringView::assign(const char*)':
../../pan/general/string-view.h:148: error: 'strlen' was not declared in this scope
../../pan/general/string-view.h: In member function 'pan::StringView&
pan::StringView::operator=(const char*)':
../../pan/general/string-view.h:149: error: 'strlen' was not declared in this scope
file-util.cc: In function 'std::string pan::file::sanitize(const pan::StringView&)':
file-util.cc:189: error: 'replace' is not a member of 'std'
file-util.cc: In function 'char* pan::file::get_unique_fname(const gchar*, const
gchar*)':
file-util.cc:226: error: 'strrchr' was not declared in this scope
/usr/include/stdio.h: In function 'bool pan::file::get_text_file_contents(const
pan::StringView&, std::string&, const char*, const char*)':
/usr/include/stdio.h:157: error: too many arguments to function 'int
remove(const char*)'
file-util.cc:301: error: at this point in file
file-util.cc:301: error: invalid operands of types 'int' and 'char*' to binary
'operator-'
make[3]: *** [file-util.o] Error 1
make[3]: *** Waiting for unfinished jobs....
In file included from file-util.h:31,
                 from line-reader.cc:7:
../../pan/general/string-view.h: In static member function 'static char*
pan::StringView::strchr(const char*, size_t, char)':
../../pan/general/string-view.h:48: error: 'memchr' was not declared in this scope
../../pan/general/string-view.h: In member function 'bool
pan::StringView::operator==(const char*) const':
../../pan/general/string-view.h:108: error: 'strlen' was not declared in this scope
../../pan/general/string-view.h: In member function 'bool
pan::StringView::operator!=(const char*) const':
../../pan/general/string-view.h:109: error: 'strlen' was not declared in this scope
../../pan/general/string-view.h: In member function 'int
pan::StringView::strncasecmp(const char*, unsigned int)':
../../pan/general/string-view.h:116: error: '::strncasecmp' has not been declared
../../pan/general/string-view.h:118: error: '::strncasecmp' has not been declared
../../pan/general/string-view.h: In member function 'char*
pan::StringView::strstr(const char*) const':
../../pan/general/string-view.h:138: error: '::strlen' has not been declared
../../pan/general/string-view.h: In member function 'void
pan::StringView::assign(const char*)':
../../pan/general/string-view.h:148: error: 'strlen' was not declared in this scope
../../pan/general/string-view.h: In member function 'pan::StringView&
pan::StringView::operator=(const char*)':
../../pan/general/string-view.h:149: error: 'strlen' was not declared in this scope
line-reader.cc: In constructor 'pan::FileLineReader::FileLineReader(const
pan::StringView&)':
line-reader.cc:16: error: 'calloc' was not declared in this scope
line-reader.cc: In destructor 'virtual pan::FileLineReader::~FileLineReader()':
line-reader.cc:29: error: 'free' was not declared in this scope
line-reader.cc: In member function 'virtual bool
pan::FileLineReader::getline(pan::StringView&)':
line-reader.cc:35: error: 'memchr' was not declared in this scope
line-reader.cc:46: error: 'memmove' was not declared in this scope
line-reader.cc:52: error: 'calloc' was not declared in this scope
line-reader.cc:53: error: 'memmove' was not declared in this scope
line-reader.cc:57: error: 'free' was not declared in this scope

Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Created attachment 306299 [details]
Proposed patch to fix the compilation

Adds includes that were implied by previous GCC versions: stdlib.h, algorithm,
etc.

Signed-off by: Pavel Polischouk <pavelvp>

*** Bug 446914 has been marked as a duplicate of this bug. ***

*** Bug 440925 has been marked as a duplicate of this bug. ***

*** Bug 449641 has been marked as a duplicate of this bug. ***

New upstream version 0.133 is available, which fixes compilation and some SECURITY issues. Please update the rpm...

This works for me: http://www.cs.umd.edu/~gaburici/pan-0.133-3.fc9.src.rpm

I will care for a new Fedora release these days.

This package has Failed to Build From Source for many months.  Per
http://fedoraproject.org/wiki/FTBFS, this package is now proposed for
removal from the distribution.  Please address this FTBFS bug
immediately, or this package will be removed from the distribution
within the next few weeks.

Thank you for your continued contributions to Fedora, and your
commitment to ensuring Fedora packages remain buildable from source
code.

I just updated pan to version 0.133 which includes the GCC 4.3 patch and build it for both rawhide and F-9.

Koji logs at http://koji.fedoraproject.org/koji/taskinfo?taskID=810394 and http://koji.fedoraproject.org/koji/taskinfo?taskID=810415

Alexander:
- The patch 'body-pane.cc.diff' has been removed as it has been upstreamed
- I've left the pushing of an F-9 update up to you