Bug 437919

Summary:	Review Request: perl-Catalyst-Controller-BindLex - Stash your lexical goodness
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Catalyst-Controller-BindLex/
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-03-19 19:40:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	437917, 437918
Bug Blocks:

Description Chris Weyl 2008-03-18 05:35:47 UTC

SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Controller-BindLex-0.03-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Controller-BindLex.spec

Description:
This plugin lets you put your lexicals on the stash and elsewhere
very easily.

Comment 1 Chris Weyl 2008-03-18 22:23:50 UTC

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521597

Comment 2 Parag AN(पराग) 2008-03-19 01:51:24 UTC

Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=521597
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
b498197c02104352563ad20ee4a5d1f9  Catalyst-Controller-BindLex-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=9,  0 wallclock secs ( 0.29 cusr +  0.02 csys =  0.31 CPU)
+ Package  perl-Catalyst-Controller-BindLex-0.03-1.fc9 =>
  Provides: perl(Catalyst::Controller::BindLex) = 0.03
  Requires: perl(Array::RefElem) perl(Carp) perl(Devel::Caller)
perl(Devel::LexAlias) perl(NEXT) perl(PadWalker) perl(Scalar::Util)
perl(attributes) perl(base) perl(strict) perl(warnings)

APPROVED.

Comment 3 Chris Weyl 2008-03-19 01:53:04 UTC

New Package CVS Request
=======================
Package Name: perl-Catalyst-Controller-BindLex
Short Description: Stash your lexical goodness
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-03-19 16:06:01 UTC

cvs done.

Comment 5 Chris Weyl 2008-03-19 16:52:00 UTC

Imported and built in rawhide, but I'm getting an odd error when trying to build
for F-7: "FAILED: BuildError: package perl-Catalyst-Controller-BindLex not in
list for tag dist-fc7-updates-candidate"

http://koji.fedoraproject.org/koji/taskinfo?taskID=522489

Comment 6 Chris Weyl 2008-03-19 19:40:14 UTC

Anyways -- that appears to have cleared up :)

Thanks for the review! :)