Bug 467239
| Summary: | Review Request: globus-gss-assist - Globus Toolkit - GSSAPI Assist library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora, steve.traylen |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 4.0-1.fc9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-05-21 23:26:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 453847, 453848, 453851, 453856, 453857, 467235, 467237 | ||
| Bug Blocks: | 453865, 478918, 478919, 478921, 478922 | ||
|
Description
Mattias Ellert
2008-10-16 14:34:17 UTC
Doxygen patch accepted upstream: http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/accept.c?r1=1.13&r2=1.14 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/display.c?r1=1.12&r2=1.13 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/export_sec_context.c?r1=1.5&r2=1.6 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/init.c?r1=1.15&r2=1.16 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/tokens_n.c?r1=1.7&r2=1.8 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/unwrap.c?r1=1.10&r2=1.11 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/wrap.c?r1=1.11&r2=1.12 Environment variable elimination patch accepted upstream: http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/programs/grid-mapfile-add-entry.in?r1=1.9&r2=1.7 http://viewcvs.globus.org/viewcvs.cgi/gsi/gss_assist/source/programs/grid-mapfile-delete-entry.in?r1=1.9&r2=1.10 This package was updated due to the renaming of the GPT package. SRPM: http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-gss-assist-4.0-0.3.fc10.src.rpm SPEC: http://www.grid.tsl.uu.se/repos/globus/info/globus-gss-assist.spec New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-gss-assist-4.0-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-gss-assist.spec Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-gss-assist-4.0-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-gss-assist.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus I went over this package. No major issues. I still have to see it building in koji in all archs and to check the resulting packages. Meanwhile I'd like to ask two questions. - rpmlints globus-gss-assist-progs.x86_64: W: no-documentation globus-gss-assist-devel.x86_64: W: no-documentation can be ignored. ? globus-gss-assist-normalization.patch seems to be rejected by upstream without apparent explanation (closed WONTFIX). What might be wrong? ? For globus-gss-assist.patch, you say "the GRIDMAPDIR patch from VDT". Who is this VDT, is it related to upstream globus? If not, would you consider submitting the patch to them? (In reply to comment #6) > I went over this package. No major issues. I still have to see it building in > koji in all archs and to check the resulting packages. Meanwhile I'd like to > ask two questions. > > - rpmlints > globus-gss-assist-progs.x86_64: W: no-documentation > globus-gss-assist-devel.x86_64: W: no-documentation > can be ignored. > > ? globus-gss-assist-normalization.patch seems to be rejected by upstream > without apparent explanation (closed WONTFIX). What might be wrong? There is nothing really wrong, it is just that upstream does not really care about certificate subject names that contain non-ascii characters. The recommended practice by upstream is to not use non-ascii characters in the certificate subject names, so it is a non-issue for them. > ? For globus-gss-assist.patch, you say "the GRIDMAPDIR patch from VDT". Who is > this VDT, is it related to upstream globus? If not, would you consider > submitting the patch to them? Globus is well aware of VDT (virtual data toolkit) - http://vdt.cs.wisc.edu/ - and their patches. They are already submitted to globus bugzilla: https://bugzilla.mcs.anl.gov/globus/show_bug.cgi?id=6192 VDT it is one of the most commonly used distribution channels for the Globus Toolkit. Many users of globus use this patch since they get globus from VDT rather than from upstream directly, so it makes sense to include it. My suspicion is that if I don't include it, I will get a feature request to include it very soon anyway. Thanks. No further questions. - koji rawhide build is fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=1362675 ---------------------------------------------------- This package (globus-gss-assist) is APPROVED by oget ---------------------------------------------------- Thank you for the review. New Package CVS Request ======================= Package Name: globus-gss-assist Short Description: Globus Toolkit - GSSAPI Assist library Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: cvs done. globus-gss-assist-4.0-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-gss-assist-4.0-1.fc10 globus-gss-assist-4.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-gss-assist-4.0-1.fc11 globus-gss-assist-4.0-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-gss-assist-4.0-1.fc9 globus-gss-assist-4.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. globus-gss-assist-4.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. globus-gss-assist-4.0-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. |