Red Hat Bugzilla – Bug 467239
Review Request: globus-gss-assist - Globus Toolkit - GSSAPI Assist library
Last modified: 2009-05-21 19:29:00 EDT
Spec URL: http://www.grid.tsl.uu.se/repos/globus/fedora/9/info/globus-gss-assist.spec
SRPM URL: http://www.grid.tsl.uu.se/repos/globus/fedora/9/src/SRPMS/globus-gss-assist-4.0-0.2.fc9.src.rpm
The Globus Toolkit is an open source software toolkit used for
building Grid systems and applications. It is being developed by the
Globus Alliance and many others all over the world. A growing number
of projects and companies are using the Globus Toolkit to unlock the
potential of grids for their cause.
The globus-gss-assist package contains:
GSSAPI Assist library
BuildRequires: globus-gsi-cert-utils-devel >= 2
BuildRequires: globus-gsi-sysconfig-devel >= 1
BuildRequires: globus-common-devel >= 3
BuildRequires: globus-gssapi-gsi-devel >= 4
BuildRequires: globus-core-devel >= 4
Based on the globus toolkit 4.2.1 release.
Applied patches submitted upstream:
Environment variable elimination patch:
globus_i_gss_assist_gridmap_parse_globusid and X509_NAME_oneline don't normalize DNs the same way:
Fix some doxygen warnings:
The package also incorporates the GRIDMAPDIR patch from VDT:
Doxygen patch accepted upstream:
Environment variable elimination patch accepted upstream:
This package was updated due to the renaming of the GPT package.
- Added s390x as 64 bit arch
- Added comment documenting source
- Adapt to changes in the globus-core package
Package updated due to new packaging guidelines
- Change defines to globals
- Remove explicit requires on library packages
Draft packaging guidelines for Globus packages are now available:
I went over this package. No major issues. I still have to see it building in koji in all archs and to check the resulting packages. Meanwhile I'd like to ask two questions.
globus-gss-assist-progs.x86_64: W: no-documentation
globus-gss-assist-devel.x86_64: W: no-documentation
can be ignored.
? globus-gss-assist-normalization.patch seems to be rejected by upstream without apparent explanation (closed WONTFIX). What might be wrong?
? For globus-gss-assist.patch, you say "the GRIDMAPDIR patch from VDT". Who is this VDT, is it related to upstream globus? If not, would you consider submitting the patch to them?
(In reply to comment #6)
> I went over this package. No major issues. I still have to see it building in
> koji in all archs and to check the resulting packages. Meanwhile I'd like to
> ask two questions.
> - rpmlints
> globus-gss-assist-progs.x86_64: W: no-documentation
> globus-gss-assist-devel.x86_64: W: no-documentation
> can be ignored.
> ? globus-gss-assist-normalization.patch seems to be rejected by upstream
> without apparent explanation (closed WONTFIX). What might be wrong?
There is nothing really wrong, it is just that upstream does not really care about certificate subject names that contain non-ascii characters. The recommended practice by upstream is to not use non-ascii characters in the certificate subject names, so it is a non-issue for them.
> ? For globus-gss-assist.patch, you say "the GRIDMAPDIR patch from VDT". Who is
> this VDT, is it related to upstream globus? If not, would you consider
> submitting the patch to them?
Globus is well aware of VDT (virtual data toolkit) - http://vdt.cs.wisc.edu/ - and their patches. They are already submitted to globus bugzilla:
VDT it is one of the most commonly used distribution channels for the Globus Toolkit. Many users of globus use this patch since they get globus from VDT rather than from upstream directly, so it makes sense to include it. My suspicion is that if I don't include it, I will get a feature request to include it very soon anyway.
Thanks. No further questions.
- koji rawhide build is fine:
This package (globus-gss-assist) is APPROVED by oget
Thank you for the review.
New Package CVS Request
Package Name: globus-gss-assist
Short Description: Globus Toolkit - GSSAPI Assist library
Branches: F-9 F-10 F-11 EL-4 EL-5
globus-gss-assist-4.0-1.fc10 has been submitted as an update for Fedora 10.
globus-gss-assist-4.0-1.fc11 has been submitted as an update for Fedora 11.
globus-gss-assist-4.0-1.fc9 has been submitted as an update for Fedora 9.
globus-gss-assist-4.0-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
globus-gss-assist-4.0-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
globus-gss-assist-4.0-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.