Bug 467420 (mingw32-gtk2)

Spec URL:
http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=3e4efcc61ee75e92533c944912e3ea317da288fa;path=/gtk2/
SRPM URL:
http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-gtk2-2.14.4-1.fc9.src.rpm

please apply:

diff -up ./mingw32-gtk2.spec.lfarkas ./mingw32-gtk2.spec
--- ./mingw32-gtk2.spec.lfarkas	2008-11-01 14:13:22.000000000 +0100
+++ ./mingw32-gtk2.spec	2008-11-01 14:14:14.000000000 +0100
@@ -4,6 +4,8 @@
 %define __find_requires %{_mingw32_findrequires}
 %define __find_provides %{_mingw32_findprovides}
 
+%define glib2_version 2.6.0
+
 Name:           mingw32-gtk2
 Version:        2.14.4
 Release:        3%{?dist}
@@ -38,11 +40,11 @@ BuildRequires:  pkgconfig
 # Native one for msgfmt
 BuildRequires:  gettext
 # Native one for glib-genmarsjal
-BuildRequires:  glib2-devel
+BuildRequires:  glib2-devel >= %{glib2_version}
 # Native one for gtk-update-icon-cache
-BuildRequires:  gtk2
+BuildRequires:  gtk2 >= %{version}
 # Native one for gdk-pixbuf-csource
-BuildRequires:  gtk2-devel
+BuildRequires:  gtk2-devel >= %{version}
 
 
 %description

(In reply to comment #2)

Please see my comments:
https://bugzilla.redhat.com/show_bug.cgi?id=467409#c2
https://bugzilla.redhat.com/show_bug.cgi?id=467402#c2

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/gtk2/mingw32-gtk2.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-gtk2-2.14.4-3.fc10.src.rpm

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/gtk2/mingw32-gtk2.spec
SRPM URL: http://www.annexia.org/tmp/mingw/fedora-rawhide/src/SRPMS/mingw32-gtk2-2.15.0-1.fc11.src.rpm

* Fri Jan 23 2009 Richard W.M. Jones <rjones> - 2.15.0-1
- Rebase to Fedora native version 2.15.0.
- Disable static libraries.
- Use _smp_mflags.
- Use find_lang macro.

Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/raw-file/tip/gtk2/mingw32-gtk2.spec
SRPM URL: http://www.annexia.org/tmp/mingw32-gtk2-2.15.0-3.fc11.src.rpm

* Fri Feb  6 2009 Richard W.M. Jones <rjones> - 2.15.0-3
- Remove documentation.
- Add license file.
- Added extra BRs suggested by auto-buildrequires.

MUST:

? rpmlint: .defs marked executable
I went back to my mingw23-libgcrypt review:
  https://bugzilla.redhat.com/show_bug.cgi?id=467403

and it looks like you ended up removing the *.def files altogether. That definitely fixes rpmlint, and I just tried rebuilding gtk-vnc after removing mingw32-gtk2's *.defs, so MinGW does not need those *.def files, but wouldn't someone trying to compile against libgcrypt on Windows need them?

What I don't know is whether they absolutely must have +x permissions. I'm guessing that chmod -x'ing them should be safe, after all, they are just header files. Should they be readded to libgcrypt?


+ package name
+ spec file name
+ package guideline-compliant
+ license complies with guidelines
+ license field accurate
+ license file not deleted
+ spec in US English
+ spec legible
+ source matches upstream
+ builds under >= 1 archs, others excluded
+ build dependencies complete
+ locales handled using %find_lang, no %{_datadir}/locale

N/A library -> ldconfig
N/A relocatable: give reason

+ own all directories
+ no dupes in %files
+ permission
+ %clean RPM_BUILD_ROOT
+ macros used consistently
+ Package contains code

N/A large docs => -doc
N/A doc not runtime dependent

N/A headers in -devel
N/A static in -static

+   if contains *.pc, req pkgconfig
N/A if libfiles are suffixed, the non-suffixed goes to devel
N/A devel requires versioned base package

N/A desktop file uses desktop-file-install
+   clean buildroot before install
+   filenames UTF-8

SHOULD
-   desc and summary contain translations if available
?   package build in mock on all architectures
    Not tested -- not all dependencies in Fedora yet, thus no Koji
+   package functioned as described
+   scriplets are sane
N/A other subpackages should require versioned base
+   if main pkg is development-wise, pkgconfig can go in main package
+   require package not files

I don't even know enough to speculate about *.def files,
so I raised a question on the mailing list:

http://lists.fedoraproject.org/pipermail/fedora-mingw/2009-February/000437.html

Thanks for the review.  I will raise a CVS request next.

New Package CVS Request
=======================
Package Name: mingw32-gtk2
Short Description: MinGW Windows Gtk2 library
Owners: rjones berrange
Branches: EL-5 F-10
InitialCC:

cvs done.

Imported into CVS but not built yet because of
dependencies on mingw32-pango, mingw32-jasper.

jasper and pango are now done, so this should probably get built soon.

I'm building them ... It's complicated by the fact that some
of the dependencies don't build correctly.

This looks here http://koji.fedoraproject.org/koji/buildinfo?buildID=94068 to be built for Rawhide but I am unable to reach it from my box.

This is NOT built for F10 yet, and nor is gtk-vnc.  The bug
will be closed automatically by Bodhi when the time comes.

mingw32-gtk2-2.15.0-3.fc10 has been submitted as an update for Fedora 10.
http://admin.fedoraproject.org/updates/mingw32-gtk2-2.15.0-3.fc10

mingw32-gtk2-2.15.0-3.fc10 has been pushed to the Fedora 10 stable repository.  If problems still persist, please make note of it in this bug report.