Bug 478922
| Summary: | Review Request: globus-ftp-control - Globus Toolkit - GridFTP Client Control Library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattias Ellert <mattias.ellert> |
| Component: | Package Review | Assignee: | Orcan Ogetbil <oget.fedora> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, oget.fedora |
| Target Milestone: | --- | Flags: | oget.fedora:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.10-1.fc10 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-06-04 21:09:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 453847, 453848, 453851, 467237, 467239, 478921 | ||
| Bug Blocks: | 478923, 478926 | ||
|
Description
Mattias Ellert
2009-01-06 01:05:35 UTC
New version - Added s390x as 64 bit arch - Added comment documenting source - Adapt to changes in the globus-core package http://www.grid.tsl.uu.se/repos/globus/fedora/10/src/SRPMS/globus-ftp-control-2.10-0.5.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/globus-ftp-control.spec Package updated due to new packaging guidelines - Change defines to globals - Remove explicit requires on library packages http://www.grid.tsl.uu.se/repos/globus/info/new/globus-ftp-control-2.10-1.fc10.src.rpm http://www.grid.tsl.uu.se/repos/globus/info/new/globus-ftp-control.spec Draft packaging guidelines for Globus packages are now available: http://fedoraproject.org/wiki/PackagingDrafts/Globus I reviewed this package and found one minor issue - koji rawhide build is fine http://koji.fedoraproject.org/koji/taskinfo?taskID=1385107 * These type of warnings may indicate misbehavior in 64bit systems warning: format '%d' expects type 'int', but argument 4 has type 'globus_size_t' Can you patch this up? Swapping %d with %zd will probably solve the issue. - rpmlint globus-ftp-control-devel.x86_64: W: no-documentation can be ignored Otherwise, the package is good to go. Please take care of the above warnings before you commit. ----------------------------------------------------- This package (globus-ftp-control) is APPROVED by oget ----------------------------------------------------- Thank you for the review - I'll fix those warnings... New Package CVS Request ======================= Package Name: globus-ftp-control Short Description: Globus Toolkit - GridFTP Client Control Library Owners: ellert Branches: F-9 F-10 F-11 EL-4 EL-5 InitialCC: CVS done. Package available in devel. globus-ftp-control-2.10-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/globus-ftp-control-2.10-1.fc10 globus-ftp-control-2.10-1.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/globus-ftp-control-2.10-1.fc9 globus-ftp-control-2.10-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/globus-ftp-control-2.10-1.fc11 globus-ftp-control-2.10-1.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. globus-ftp-control-2.10-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. globus-ftp-control-2.10-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: globus-ftp-control Updated Description: Globus Toolkit - GridFTP Control Library Upstream changed their package description in their new release. This change is requested to reflect this. No need to do a cvs request for these. They update as your update your package. ;) It's already correct. |