Bug 490232
Summary: | RFE: s-c-date doesn't centre map when a GMT[+/-x] zone is selected | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | David Timms <dtimms> | ||||||
Component: | system-config-date | Assignee: | Nils Philippsen <nphilipp> | ||||||
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | rawhide | CC: | nphilipp | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | 427177 | Environment: | |||||||
Last Closed: | 2016-08-10 14:37:57 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
David Timms
2009-03-13 22:48:24 UTC
Created attachment 335203 [details]
assign the GMT[x] entries to have latitutude and longitude
This patch takes the simpler approach of placing each of the GMT zone times as yellow dots round the equator. Both list selection or scrolling, as well as map point selection changes track the relevant item.
A non-integer long/lat is created so that code in timezone_map_gui.py does not assume that either value is zero should alter the operation to not map the point.
Also, wraps overly negative timezones into the positive longitudes.
Created attachment 335204 [details]
trick the sort routine into leaving the GMT zone item order as created
Additional patch so that the GMT list is no longer sorted alphanumerically. This leaves the GMT zones in -14,-13,-12,...,11,12 order.
To achieve this, the initial sort field is created to be ascending based on original item position, and starting at 10 so that 10<11 etc, rather than 1<10<11<2
A possibly better implementation would be to initially exclude the GMT group from the copied (sort) list, sort the first part, then append the GMT part in the original order, at the end.
Is there any interest in this expansion of the time zone markings on the map ? I don't think having map markers for GMT+/-... timezones is a good idea (they're non-geographic timezones ;-). I'll see whether I can make the markers invisible for them so selecting one from the list would pan the map accordingly (if zoomed in). Thanks for the sorting patch, I've applied it to git (though I'll probably rework the sorting anyway to make it more robust). Thanks for taking the time to submit this request for enhancement. Unfortunately, I haven't gotten around to implement this feature, sorry for that. Because I don't actively develop system-config-date anymore, I won't likely find the time to work on this ticket, so I'll close this bug now. |