Bug 512273
| Summary: | Review Request: php-pear-File-Bittorrent2 - Decode and Encode data in Bittorrent format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Nalley <david> |
| Component: | Package Review | Assignee: | Paul W. Frields <stickster> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, ian, notting, stickster |
| Target Milestone: | --- | Flags: | stickster:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-23 20:06:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 505938, 506038 | ||
|
Description
David Nalley
2009-07-16 22:59:29 UTC
I agree with that approach and have a package together: http://pfrields.fedorapeople.org/packages/SPECS/php-pear-File-Bittorrent.spec http://pfrields.fedorapeople.org/packages/SRPMS/php-pear-File-Bittorrent-1.3.1-2.fc11.src.rpm If you want to use it, you're welcome. Paul: Excellent! I hope we haven't been duplicating work. It did save me some time. Spec URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2-1.3.1-2.fc11.src.rpm [ OK ] specfiles match:
211e7e1e97cc16f38cd3a72981f1e0019cc4e958ff096744efdd659dcd818d75 php-pear-File-Bittorrent2.spec
211e7e1e97cc16f38cd3a72981f1e0019cc4e958ff096744efdd659dcd818d75 rpmbuild/SPECS/php-pear-File-Bittorrent2.spec
[ OK ] source files match upstream:
674d354ca7a03de5f2020ad9ec2779f1a17c5c6e38d002964f7dfc0684a656eb File_Bittorrent2-1.3.1.tgz
674d354ca7a03de5f2020ad9ec2779f1a17c5c6e38d002964f7dfc0684a656eb File_Bittorrent2-1.3.1.tgz
[ OK ] package meets naming and versioning guidelines.
[ OK ] spec is properly named, cleanly written, and uses macros consistently.
I'd make the %description paragraph easier to read, but that's totally subjective.
[ OK ] dist tag is present.
[ OK ] build root is correct.
[ OK ] license field matches the actual license.
[ OK ] license is open source-compatible.
[ N/A ] license text included in package.
[ OK ] BuildRequires are proper.
[ N/A ] compiler flags are appropriate.
[ OK ] %clean is present.
[ OK ] package builds in mock.
[ OK ] package installs properly.
[ N/A ] debuginfo package looks complete.
[ OK ] rpmlint is silent.
[ OK ] final provides and requires are sane
[FAILED] %check is present and all tests pass:
Needs to Buildreq: php-pear-PHPUnit, so tests can be run; then add a %check section with the following:
cd %{pear_name}-%{version}
php -f Tests/AllTests.php
[ N/A ] no shared libraries are added to the regular linker search paths.
[ OK ] owns the directories it creates.
[FAILED] doesn't own any directories it shouldn't.
Should not own %{pear_phpdir}/{test,doc}
[ OK ] no duplicates in %files.
[ OK ] file permissions are appropriate.
[ N/A ] scriptlets match those on ScriptletSnippets page.
[ OK ] code, not content.
[ OK ] documentation is small, so no -docs subpackage is necessary.
[ OK ] %docs are not necessary for the proper functioning of the package.
[ OK ] no headers.
[ OK ] no pkgconfig files.
[ OK ] no libtool .la droppings.
[ OK ] desktop files valid and installed properly.
I would remove the %files line for %{pear_phpdir}/* and replace it with the following lines:
%{pear_phpdir}/File
%{pear_test}/%{pear_name}
Once that's done I can approve.
Spec URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2-1.3.1-4.fc11.src.rpm Paul: I think that I have those items taken care of. Approved per comment #3. If you need the CVS admins to take some action, could you let us know what it is by pasting in a CVS request? http://fedoraproject.org/wiki/CVS_admin_requests Sorry didn't realize CVS flag had been set: New Package CVS Request ======================= Package Name: php-pear-File-Bittorrent2 Short Description: Decode and encode data in Bittorrent format Owners: ke4qqq sparks Branches: F-10 F-11 EL-5 InitialCC: CVS done. |