Spec URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2-1.3.1-1.fc11.src.rpm Description: This package consists of three classes which handles the encoding and decoding of data in Bittorrent format. You can also extract useful informations from .torrent files, create .torrent files and query the torrent's scrape page to get its statistics. PHP5 only. [ke4qqq@nalleyt61 SPECS]$ rpmlint ./php-pear-File-Bittorrent2.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [ke4qqq@nalleyt61 SPECS]$ rpmlint ../SRPMS/php-pear-File-Bittorrent2-1.3.1-1.fc11.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [ke4qqq@nalleyt61 SPECS]$ rpmlint ../RPMS/noarch/php-pear-File-Bittorrent2-1.3.1-1.fc11.noarch.rpm php-pear-File-Bittorrent2.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/php-pear-File-Bittorrent2-1.3.1/torrentinfo.php php-pear-File-Bittorrent2.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/php-pear-File-Bittorrent2-1.3.1/scrape.php php-pear-File-Bittorrent2.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/php-pear-File-Bittorrent2-1.3.1/example.php 1 packages and 0 specfiles checked; 0 errors, 3 warnings. So this spec was created with 'pear make-rpm-spec Foo.tgz' I tried using dos2unix/sed to correct the end of line encoding. However the generated XML file contains md5sums of the files. So then those files aren't included and several cp/mv directives in the spec deal with those files and it ends up blowing up. I am interested in ways to mitigate this since using pear make-rpm-spec is an approved manner of generating specs and the xml file is required. (suppose we could modify the xml file)
I agree with that approach and have a package together: http://pfrields.fedorapeople.org/packages/SPECS/php-pear-File-Bittorrent.spec http://pfrields.fedorapeople.org/packages/SRPMS/php-pear-File-Bittorrent-1.3.1-2.fc11.src.rpm If you want to use it, you're welcome.
Paul: Excellent! I hope we haven't been duplicating work. It did save me some time. Spec URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2-1.3.1-2.fc11.src.rpm
[ OK ] specfiles match: 211e7e1e97cc16f38cd3a72981f1e0019cc4e958ff096744efdd659dcd818d75 php-pear-File-Bittorrent2.spec 211e7e1e97cc16f38cd3a72981f1e0019cc4e958ff096744efdd659dcd818d75 rpmbuild/SPECS/php-pear-File-Bittorrent2.spec [ OK ] source files match upstream: 674d354ca7a03de5f2020ad9ec2779f1a17c5c6e38d002964f7dfc0684a656eb File_Bittorrent2-1.3.1.tgz 674d354ca7a03de5f2020ad9ec2779f1a17c5c6e38d002964f7dfc0684a656eb File_Bittorrent2-1.3.1.tgz [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. I'd make the %description paragraph easier to read, but that's totally subjective. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [ N/A ] license text included in package. [ OK ] BuildRequires are proper. [ N/A ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ N/A ] debuginfo package looks complete. [ OK ] rpmlint is silent. [ OK ] final provides and requires are sane [FAILED] %check is present and all tests pass: Needs to Buildreq: php-pear-PHPUnit, so tests can be run; then add a %check section with the following: cd %{pear_name}-%{version} php -f Tests/AllTests.php [ N/A ] no shared libraries are added to the regular linker search paths. [ OK ] owns the directories it creates. [FAILED] doesn't own any directories it shouldn't. Should not own %{pear_phpdir}/{test,doc} [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ N/A ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ OK ] %docs are not necessary for the proper functioning of the package. [ OK ] no headers. [ OK ] no pkgconfig files. [ OK ] no libtool .la droppings. [ OK ] desktop files valid and installed properly. I would remove the %files line for %{pear_phpdir}/* and replace it with the following lines: %{pear_phpdir}/File %{pear_test}/%{pear_name} Once that's done I can approve.
Spec URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-pear-File-Bittorrent2-1.3.1-4.fc11.src.rpm Paul: I think that I have those items taken care of.
Approved per comment #3.
If you need the CVS admins to take some action, could you let us know what it is by pasting in a CVS request? http://fedoraproject.org/wiki/CVS_admin_requests
Sorry didn't realize CVS flag had been set: New Package CVS Request ======================= Package Name: php-pear-File-Bittorrent2 Short Description: Decode and encode data in Bittorrent format Owners: ke4qqq sparks Branches: F-10 F-11 EL-5 InitialCC:
CVS done.