Bug 521067
| Summary: | Review Request: felix-osgi-core - Felix OSGi R4 Core Bundle | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
| Component: | Package Review | Assignee: | Andrew Overholt <overholt> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dwalluck, fedora-package-review, notting, overholt |
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-09-04 13:44:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 486360, 521069 | ||
|
Description
Alexander Kurtakov
2009-09-03 12:39:22 UTC
Only issue: line 40 is too long - md5sums and sha1sums match - licensing good - naming fine - rpmlint clean: $ rpmlint /home/overholt/rpmbuild/SRPMS/felix-osgi-core-1.2.0-1.fc11.src.rpm /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-1.2.0-1.fc11.noarch.rpm /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-javadoc-1.2.0-1.fc11.noarch.rpm felix-osgi-core.noarch: W: non-conffile-in-etc /etc/maven/fragments/felix-osgi-core 3 packages and 0 specfiles checked; 0 errors, 1 warnings. For those playing along at home, Alex and I discussed the possibility of using the Eclipse version of these OSGi classes. This would mean a tighter loop at a build level between Eclipse and Jetty. It also would mean porting work to bring Felix up to the different (newer) versions of these OSGi classes in Eclipse. At this time, it's probably easiest to have this separate, small implementation. Also, it may be best to coordinate with the JPackage folks to split their monolithic felix package like you've done so that there aren't file conflicts. At the moment, since Fedora doesn't explicitly support JPackage compatibility, this is probably okay. Longer term, it'd be nice to interoperate. (In reply to comment #1) > Only issue: line 40 is too long Fixed. > > - md5sums and sha1sums match > - licensing good > - naming fine > - rpmlint clean: > > $ rpmlint /home/overholt/rpmbuild/SRPMS/felix-osgi-core-1.2.0-1.fc11.src.rpm > /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-1.2.0-1.fc11.noarch.rpm > /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-javadoc-1.2.0-1.fc11.noarch.rpm > felix-osgi-core.noarch: W: non-conffile-in-etc > /etc/maven/fragments/felix-osgi-core > 3 packages and 0 specfiles checked; 0 errors, 1 warnings. > > For those playing along at home, Alex and I discussed the possibility of using > the Eclipse version of these OSGi classes. This would mean a tighter loop at a > build level between Eclipse and Jetty. It also would mean porting work to > bring Felix up to the different (newer) versions of these OSGi classes in > Eclipse. At this time, it's probably easiest to have this separate, small > implementation. > > Also, it may be best to coordinate with the JPackage folks to split their > monolithic felix package like you've done so that there aren't file conflicts. > At the moment, since Fedora doesn't explicitly support JPackage compatibility, > this is probably okay. Longer term, it'd be nice to interoperate. New sources: Spec URL: http://akurtakov.fedorapeople.org/felix-osgi-core.spec SRPM URL: http://akurtakov.fedorapeople.org/felix-osgi-core-1.2.0-2.fc11.src.rpm Thanks, approved. New Package CVS Request ======================= Package Name: felix-osgi-core Short Description: Felix OSGi R4 Core Bundle Owners: akurtakov Branches: InitialCC: CVS Done Build in rawhide. Build in rawhide. |