Bug 521069 - Review Request: felix-osgi-obr - Felix OSGi OBR Service API
Summary: Review Request: felix-osgi-obr - Felix OSGi OBR Service API
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 521067
Blocks: 486360
TreeView+ depends on / blocked
 
Reported: 2009-09-03 12:50 UTC by Alexander Kurtakov
Modified: 2009-09-04 13:47 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-04 13:47:17 UTC
overholt: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Alexander Kurtakov 2009-09-03 12:50:07 UTC
Spec URL: http://akurtakov.fedorapeople.org/felix-osgi-obr.spec
SRPM URL: http://akurtakov.fedorapeople.org/felix-osgi-obr-1.0.2-1.fc11.src.rpm
Description: OSGi OBR Service API.

Comment 1 Andrew Overholt 2009-09-03 14:34:59 UTC
Only issue:  line 42 is too long :)

- md5sums match upstream
- licensing fine
- builds and installs fine
- macros sane
- naming good
- files okay
- rpmlint clean (maven warning is okay):

$ rpmlint /home/overholt/rpmbuild/SRPMS/felix-osgi-obr-1.0.2-1.fc11.src.rpm /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-obr-1.0.2-1.fc11.noarch.rpm /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-obr-javadoc-1.0.2-1.fc11.noarch.rpm
felix-osgi-obr.noarch: W: non-conffile-in-etc /etc/maven/fragments/felix-osgi-obr
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

As I said in bug #521067, it may be best to coordinate with the JPackage folks to split their monolithic felix package like you've done so that there aren't file conflicts.  At the moment, since Fedora doesn't explicitly support JPackage compatibility, this is probably okay.  Longer term, it'd be nice to interoperate.

Comment 2 Alexander Kurtakov 2009-09-03 14:52:58 UTC
(In reply to comment #1)
> Only issue:  line 42 is too long :)
Fixed.
> 
> - md5sums match upstream
> - licensing fine
> - builds and installs fine
> - macros sane
> - naming good
> - files okay
> - rpmlint clean (maven warning is okay):
> 
> $ rpmlint /home/overholt/rpmbuild/SRPMS/felix-osgi-obr-1.0.2-1.fc11.src.rpm
> /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-obr-1.0.2-1.fc11.noarch.rpm
> /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-obr-javadoc-1.0.2-1.fc11.noarch.rpm
> felix-osgi-obr.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/felix-osgi-obr
> 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> As I said in bug #521067, it may be best to coordinate with the JPackage folks
> to split their monolithic felix package like you've done so that there aren't
> file conflicts.  At the moment, since Fedora doesn't explicitly support
> JPackage compatibility, this is probably okay.  Longer term, it'd be nice to
> interoperate.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/felix-osgi-obr.spec
SRPM URL: http://akurtakov.fedorapeople.org/felix-osgi-obr-1.0.2-2.fc11.src.rpm

Comment 3 Andrew Overholt 2009-09-03 15:01:50 UTC
Thanks, approved.

Comment 4 Alexander Kurtakov 2009-09-03 15:03:48 UTC
New Package CVS Request
=======================
Package Name: felix-osgi-obr
Short Description: Felix OSGi OBR Service API
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Dennis Gilmore 2009-09-03 15:10:47 UTC
CVS Done

Comment 6 Alexander Kurtakov 2009-09-04 13:47:17 UTC
Build in rawhide.


Note You need to log in before you can comment on or make changes to this bug.