Bug 521067 - Review Request: felix-osgi-core - Felix OSGi R4 Core Bundle
Summary: Review Request: felix-osgi-core - Felix OSGi R4 Core Bundle
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andrew Overholt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 486360 521069
TreeView+ depends on / blocked
 
Reported: 2009-09-03 12:39 UTC by Alexander Kurtakov
Modified: 2009-09-04 13:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-04 13:44:54 UTC
overholt: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Alexander Kurtakov 2009-09-03 12:39:22 UTC
Spec URL: http://akurtakov.fedorapeople.org/felix-osgi-core.spec
SRPM URL: http://akurtakov.fedorapeople.org/felix-osgi-core-1.2.0-1.fc11.src.rpm
Description: OSGi Service Platform Release 4 Core Interfaces and Classes.

Comment 1 Andrew Overholt 2009-09-03 13:37:06 UTC
Only issue:  line 40 is too long

- md5sums and sha1sums match
- licensing good
- naming fine
- rpmlint clean:

$ rpmlint /home/overholt/rpmbuild/SRPMS/felix-osgi-core-1.2.0-1.fc11.src.rpm /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-1.2.0-1.fc11.noarch.rpm /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-javadoc-1.2.0-1.fc11.noarch.rpm
felix-osgi-core.noarch: W: non-conffile-in-etc /etc/maven/fragments/felix-osgi-core
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

For those playing along at home, Alex and I discussed the possibility of using the Eclipse version of these OSGi classes.  This would mean a tighter loop at a build level between Eclipse and Jetty.  It also would mean porting work to bring Felix up to the different (newer) versions of these OSGi classes in Eclipse.  At this time, it's probably easiest to have this separate, small implementation.

Also, it may be best to coordinate with the JPackage folks to split their monolithic felix package like you've done so that there aren't file conflicts.  At the moment, since Fedora doesn't explicitly support JPackage compatibility, this is probably okay.  Longer term, it'd be nice to interoperate.

Comment 2 Alexander Kurtakov 2009-09-03 14:03:10 UTC
(In reply to comment #1)
> Only issue:  line 40 is too long
Fixed.
> 
> - md5sums and sha1sums match
> - licensing good
> - naming fine
> - rpmlint clean:
> 
> $ rpmlint /home/overholt/rpmbuild/SRPMS/felix-osgi-core-1.2.0-1.fc11.src.rpm
> /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-1.2.0-1.fc11.noarch.rpm
> /home/overholt/rpmbuild/RPMS/noarch/felix-osgi-core-javadoc-1.2.0-1.fc11.noarch.rpm
> felix-osgi-core.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/felix-osgi-core
> 3 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> For those playing along at home, Alex and I discussed the possibility of using
> the Eclipse version of these OSGi classes.  This would mean a tighter loop at a
> build level between Eclipse and Jetty.  It also would mean porting work to
> bring Felix up to the different (newer) versions of these OSGi classes in
> Eclipse.  At this time, it's probably easiest to have this separate, small
> implementation.
> 
> Also, it may be best to coordinate with the JPackage folks to split their
> monolithic felix package like you've done so that there aren't file conflicts. 
> At the moment, since Fedora doesn't explicitly support JPackage compatibility,
> this is probably okay.  Longer term, it'd be nice to interoperate.  

New sources:
Spec URL: http://akurtakov.fedorapeople.org/felix-osgi-core.spec
SRPM URL:
http://akurtakov.fedorapeople.org/felix-osgi-core-1.2.0-2.fc11.src.rpm

Comment 3 Andrew Overholt 2009-09-03 14:23:03 UTC
Thanks, approved.

Comment 4 Alexander Kurtakov 2009-09-03 14:36:10 UTC
New Package CVS Request
=======================
Package Name: felix-osgi-core
Short Description: Felix OSGi R4 Core Bundle
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Dennis Gilmore 2009-09-03 15:10:10 UTC
CVS Done

Comment 6 Alexander Kurtakov 2009-09-04 13:44:38 UTC
Build in rawhide.

Comment 7 Alexander Kurtakov 2009-09-04 13:45:30 UTC
Build in rawhide.


Note You need to log in before you can comment on or make changes to this bug.