Bug 527428

Summary:	Review Request: python-remoteobjects - An Object RESTational Model
Product:	[Fedora] Fedora	Reporter:	Sebastian Dziallas <sebastian>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-10-21 18:42:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	527319, 527433, 527445

Description Sebastian Dziallas 2009-10-06 11:54:59 UTC

Spec URL: http://sdz.fedorapeople.org/rpmbuild/python-remoteobjects.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/python-remoteobjects-1.0-1.fc11.src.rpm
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1730270

[sebastian@localhost SRPMS]$ rpmlint -vi python-remoteobjects-1.0-1.fc11.src.rpm 
python-remoteobjects.src: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[sebastian@localhost noarch]$ rpmlint -vi python-remoteobjects-1.0-1.fc11.noarch.rpm 
python-remoteobjects.noarch: I: checking
python-remoteobjects.noarch: E: explicit-lib-dependency python-httplib2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

1 packages and 0 specfiles checked; 1 errors, 0 warnings.

Ignoring this since it's written in Python...
This is another requirement in the effort to package TypePad Motion for Fedora.

Comment 1 Sebastian Dziallas 2009-10-06 12:06:58 UTC

New build to add a previously missing BR.

Spec URL: http://sdz.fedorapeople.org/rpmbuild/python-remoteobjects.spec
SRPM URL:
http://sdz.fedorapeople.org/rpmbuild/python-remoteobjects-1.0-2.fc11.src.rpm

Comment 2 Parag AN(पराग) 2009-10-07 07:02:06 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1732363
+ rpmlint output for SRPM and for RPM gave
python-remoteobjects.noarch: E: explicit-lib-dependency python-httplib2
==> can be ignored.
+ source files match upstream url
b2dd7e22a99d8726dd31b41b11efd2d47135bbf3  remoteobjects-1.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 3 Sebastian Dziallas 2009-10-07 18:19:07 UTC

New Package CVS Request
=======================
Package Name: python-remoteobjects
Short Description: An Object RESTational Model
Owners: sdz
Branches: F-11 F-12 EL-5

Comment 4 Kevin Fenzi 2009-10-08 05:55:05 UTC

cvs done.

Comment 5 Parag AN(पराग) 2009-10-21 06:30:34 UTC

If this package is built for all required branches, can you close this review?

Comment 6 Sebastian Dziallas 2009-10-21 18:42:57 UTC

All branches built. Closing.