Bug 527433 - Review Request: python-typepad - Connectivity to the TypePad API through remote objects
Summary: Review Request: python-typepad - Connectivity to the TypePad API through remo...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 527316 527428 527431
Blocks: 527319 527445
TreeView+ depends on / blocked
 
Reported: 2009-10-06 12:14 UTC by Sebastian Dziallas
Modified: 2009-10-21 18:43 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2009-10-21 18:43:18 UTC
Type: ---
Embargoed:
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Sebastian Dziallas 2009-10-06 12:14:56 UTC
Spec URL: http://sdz.fedorapeople.org/rpmbuild/python-typepad.spec
SRPM URL: http://sdz.fedorapeople.org/rpmbuild/python-typepad-1.0-1.fc11.src.rpm
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1730291

[sebastian@localhost SRPMS]$ rpmlint -vi python-typepad-1.0-1.fc11.src.rpm 
python-typepad.src: I: checking
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[sebastian@localhost noarch]$ rpmlint -vi python-typepad-1.0-1.fc11.noarch.rpm 
python-typepad.noarch: I: checking
python-typepad.noarch: E: explicit-lib-dependency python-httplib2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

1 packages and 0 specfiles checked; 1 errors, 0 warnings.

I guess this can be ignored (it's a Python package).
This is another requirement for getting TypePad Motion into Fedora.

Comment 1 Sebastian Dziallas 2009-10-06 12:18:17 UTC
On a side-note, this package depends on python-batchhttp, python-oauth, and python-remoteobjects, which have all been submitted for review, too.

Comment 2 Parag AN(पराग) 2009-10-07 09:46:43 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1730291
+ rpmlint output for SRPM and for RPM gave
python-typepad.noarch: E: explicit-lib-dependency python-httplib2
==> can be ignored.
+ source files match upstream url
eb641271caf164e38174c28c72fca7c9e712deb4  typepad-1.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 3 Sebastian Dziallas 2009-10-07 18:24:00 UTC
New Package CVS Request
=======================
Package Name: python-typepad
Short Description: Connectivity to the TypePad API through remote objects
Owners: sdz
Branches: F-11 F-12 EL-5

Comment 4 Kevin Fenzi 2009-10-08 05:56:58 UTC
cvs done.

Comment 5 Parag AN(पराग) 2009-10-21 06:29:14 UTC
If this package is built for all required branches, can you close this review?

Comment 6 Sebastian Dziallas 2009-10-21 18:43:18 UTC
All branches built. Closing.


Note You need to log in before you can comment on or make changes to this bug.