Bug 528638

Created attachment 365400 [details]
s-c-h - result in terminal

Crash in new  
system-config-httpd-1.4.6-1.fc12.noarch

see atthacment 
stared from terminal , root password, logg from terminal

ping!

This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Hello.

This bug may be buffer overrun in alchemist.

diff -up alchemist-1.0.37/src/refstr.c.orig alchemist-1.0.37/src/refstr.c
--- alchemist-1.0.37/src/refstr.c.orig	2009-11-20 02:47:57.739762988 +0900
+++ alchemist-1.0.37/src/refstr.c	2009-11-20 02:47:40.739667841 +0900
@@ -123,7 +123,7 @@ refstr_malloc_refstr(const char * str, s
 	char *string;
 
 	/* malloc space for the meta data and the string */
-	rstr_h_p = (refstr_head *) malloc (sizeof(refstr_head) + s_len); 
+	rstr_h_p = (refstr_head *) malloc (sizeof(refstr_head) + s_len + 1); 
 
 	/* copy the string, the length, and init the refcount */
 	string = (char *) &rstr_h_p->string;

I'm still seeing this error, and I don't see any builds of system-config-httpd or alchemist in koji, is someone able to apply the patch in comment #4 ?

ok, I've done the decent thing and worked out how to test the patch myself, with the code change from comment #4 I am still unable to run system-config-httpd, I get the same error with only the addresses different (obviosuly).

So as far as I can tell this isn't related to the code change mentioned. I'm new to all this, and don't even know any c so I'm hardly in a position to know if the fix mentioned is relevant or not, but for me it doesn't seem to fix the problem.

*** Bug 542534 has been marked as a duplicate of this bug. ***

*** Bug 542792 has been marked as a duplicate of this bug. ***

*** Bug 544202 has been marked as a duplicate of this bug. ***

Sorry for the late response, been a bit underwater here lately with work.

Anyway, this looks like a bug in alchemist, but i wanted to get rid of using it
for a while anyway.

So most likely i'll just rewrite the backend code of s-c-h. I hope to get to
that over the holidays, so bear with me till early January for a fix.

I might be able to come up with a "workaround" but need to see if i can still
find the old code for my alchemist written completely in python.

Thanks & regards, Phil

Thank you very much, Phil, for the effort ;)

Ok, very brief heads up: As it really bothered my yesterday evening i dug out some very old code i had where i implemented the alchemist completely in python in single day.

It needed a bit of tweaking here and there but it's working now on my local box so the C part of alchemist isn't needed anymore, at least for my code. And as far as i can tell s-c-h is the last consumer of alchemist, so we might be able to just drop it completely real soon then.

I'll run a few more tests in the next few days. If all goes well i'll post a workaround here for now. You'll basically have to copy 2 files into your /usr/lib[64]/python2.6/site-packages directory then, one of them basically enhancing the original Alchemist.py to support PyAlchemist and the PyAlchemist.py itself.

Thanks & regards, Phil

Phil,
  Were you able to get the workaround tested for this yet?

Ah ye, i did the tests and they seem to work nicely. I'll put up the new files on my fedora page today or tomorrow with a quick guide how to use them here.

Sorry for the delay.

Thanks & regards, Phil

OK, finally copied the files over. Quick guide for the workaround:

Copy the files

http://pknirsch.fedorapeople.org/src/Alchemist.py
http://pknirsch.fedorapeople.org/src/PyAlchemist.py

to your python site packages directory, which can be typically found here:

/usr/lib/python2.6/site-packages

or

/usr/lib64/python2.6/site-packages

Afterwards just start system-config-httpd as before and it shouldn't crash anymore. It might be a tad slower and use a bit more memory, but for the amount of data we use in Alchemist this shouldn't be noticeable.

Please give me a heads-up if this works for you and i'll coordinate with Tim Waugh (maintainer of alchemist) to drop Alchemist and i'll integrate those changes directly into s-c-h.

Thanks & regards, Phil

That hasn't worked for me, I still get the crash.

Do I need to un-install the current alchemist?

I noticed that the pyalchemist files that are already in that directory are not currently capitalised as your file names are, could that be an issue?

actually strike that, it doesn't look like the same crash...

*** buffer overflow detected ***: /usr/bin/python terminated
======= Backtrace: =========
/lib64/libc.so.6(__fortify_fail+0x37)[0x3754cf75e7]
/lib64/libc.so.6[0x3754cf5600]
/lib64/libc.so.6(__strncpy_chk+0x17b)[0x3754cf48bb]
/usr/lib64/libalchemist.so.0(refstr_nget+0x270)[0x7f38b610ca20]
/usr/lib64/libalchemist.so.0(AdmContext_new+0x99)[0x7f38b61054d9]
/usr/lib64/libalchemist.so.0(_adm_parse_start_element+0x98e)[0x7f38b6108ece]
/lib64/libglib-2.0.so.0[0x375683f482]
/lib64/libglib-2.0.so.0(g_markup_parse_context_parse+0x1052)[0x3756840eb2]
/usr/lib64/libalchemist.so.0(AdmContext_fromXML+0x7b)[0x7f38b61083bb]
/usr/lib64/python2.6/site-packages/_alchemistmodule.so(+0x553c)[0x7f38b631b53c]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalFrameEx+0x5282)[0x37614dca82]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCodeEx+0x875)[0x37614de4e5]
/usr/lib64/libpython2.6.so.1.0[0x376146dbcb]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0[0x3761458a5f]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0(PyEval_CallObjectWithKeywords+0x43)[0x37614d6cc3]
/usr/lib64/libpython2.6.so.1.0(PyInstance_New+0x76)[0x37614581b6]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalFrameEx+0x4d8d)[0x37614dc58d]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalFrameEx+0x5877)[0x37614dd077]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCodeEx+0x875)[0x37614de4e5]
/usr/lib64/libpython2.6.so.1.0[0x376146dbcb]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0[0x3761458a5f]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0(PyEval_CallObjectWithKeywords+0x43)[0x37614d6cc3]
/usr/lib64/libpython2.6.so.1.0(PyInstance_New+0x76)[0x37614581b6]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalFrameEx+0x4d8d)[0x37614dc58d]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCodeEx+0x875)[0x37614de4e5]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCode+0x32)[0x37614de5f2]
/usr/lib64/libpython2.6.so.1.0(PyImport_ExecCodeModuleEx+0xc2)[0x37614ee582]
/usr/lib64/libpython2.6.so.1.0[0x37614eea66]
/usr/lib64/libpython2.6.so.1.0[0x37614eff85]
/usr/lib64/libpython2.6.so.1.0[0x37614f0214]
/usr/lib64/libpython2.6.so.1.0[0x37614f0862]
/usr/lib64/libpython2.6.so.1.0(PyImport_ImportModuleLevel+0x44)[0x37614f0dc4]
/usr/lib64/libpython2.6.so.1.0[0x37614d674f]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0(PyEval_CallObjectWithKeywords+0x43)[0x37614d6cc3]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalFrameEx+0x1e31)[0x37614d9631]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCodeEx+0x875)[0x37614de4e5]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCode+0x32)[0x37614de5f2]
/usr/lib64/libpython2.6.so.1.0(PyImport_ExecCodeModuleEx+0xc2)[0x37614ee582]
/usr/lib64/libpython2.6.so.1.0[0x37614eea66]
/usr/lib64/libpython2.6.so.1.0[0x37614eff85]
/usr/lib64/libpython2.6.so.1.0[0x37614f0214]
/usr/lib64/libpython2.6.so.1.0[0x37614f0862]
/usr/lib64/libpython2.6.so.1.0(PyImport_ImportModuleLevel+0x44)[0x37614f0dc4]
/usr/lib64/libpython2.6.so.1.0[0x37614d674f]
/usr/lib64/libpython2.6.so.1.0(PyObject_Call+0x53)[0x3761443b33]
/usr/lib64/libpython2.6.so.1.0(PyEval_CallObjectWithKeywords+0x43)[0x37614d6cc3]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalFrameEx+0x1e31)[0x37614d9631]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCodeEx+0x875)[0x37614de4e5]
/usr/lib64/libpython2.6.so.1.0(PyEval_EvalCode+0x32)[0x37614de5f2]
/usr/lib64/libpython2.6.so.1.0[0x37614f965c]
/usr/lib64/libpython2.6.so.1.0(PyRun_FileExFlags+0x90)[0x37614f9730]
/usr/lib64/libpython2.6.so.1.0(PyRun_SimpleFileExFlags+0xdc)[0x37614fab0c]
/usr/lib64/libpython2.6.so.1.0(Py_Main+0xaa9)[0x3761507389]
/lib64/libc.so.6(__libc_start_main+0xfd)[0x3754c1eb1d]
/usr/bin/python[0x400649]
======= Memory map: ========
00400000-00401000 r-xp 00000000 fd:00 42749                              /usr/bin/python
00600000-00602000 rw-p 00000000 fd:00 42749                              /usr/bin/python
00d8e000-01773000 rw-p 00000000 00:00 0                                  [heap]
3754800000-375481e000 r-xp 00000000 fd:00 5756                           /lib64/ld-2.11.1.so
3754a1d000-3754a1e000 r--p 0001d000 fd:00 5756                           /lib64/ld-2.11.1.so
3754a1e000-3754a1f000 rw-p 0001e000 fd:00 5756                           /lib64/ld-2.11.1.so
3754a1f000-3754a20000 rw-p 00000000 00:00 0 
3754c00000-3754d6f000 r-xp 00000000 fd:00 11744                          /lib64/libc-2.11.1.so
3754d6f000-3754f6f000 ---p 0016f000 fd:00 11744                          /lib64/libc-2.11.1.so
3754f6f000-3754f73000 r--p 0016f000 fd:00 11744                          /lib64/libc-2.11.1.so
3754f73000-3754f74000 rw-p 00173000 fd:00 11744                          /lib64/libc-2.11.1.so
3754f74000-3754f79000 rw-p 00000000 00:00 0 
3755000000-3755002000 r-xp 00000000 fd:00 82190                          /lib64/libdl-2.11.1.so
3755002000-3755202000 ---p 00002000 fd:00 82190                          /lib64/libdl-2.11.1.so
3755202000-3755203000 r--p 00002000 fd:00 82190                          /lib64/libdl-2.11.1.so
3755203000-3755204000 rw-p 00003000 fd:00 82190                          /lib64/libdl-2.11.1.so
3755400000-3755417000 r-xp 00000000 fd:00 14026                          /lib64/libpthread-2.11.1.so
3755417000-3755616000 ---p 00017000 fd:00 14026                          /lib64/libpthread-2.11.1.so
3755616000-3755617000 r--p 00016000 fd:00 14026                          /lib64/libpthread-2.11.1.so
3755617000-3755618000 rw-p 00017000 fd:00 14026                          /lib64/libpthread-2.11.1.so
3755618000-375561c000 rw-p 00000000 00:00 0 
3755800000-3755883000 r-xp 00000000 fd:00 9817                           /lib64/libm-2.11.1.so
3755883000-3755a82000 ---p 00083000 fd:00 9817                           /lib64/libm-2.11.1.so
3755a82000-3755a83000 r--p 00082000 fd:00 9817                           /lib64/libm-2.11.1.so
3755a83000-3755a84000 rw-p 00083000 fd:00 9817                           /lib64/libm-2.11.1.so
3755c00000-3755c15000 r-xp 00000000 fd:00 82186                          /lib64/libz.so.1.2.3
3755c15000-3755e14000 ---p 00015000 fd:00 82186                          /lib64/libz.so.1.2.3
3755e14000-3755e15000 rw-p 00014000 fd:00 82186                          /lib64/libz.so.1.2.3
3756000000-3756007000 r-xp 00000000 fd:00 14226                          /lib64/librt-2.11.1.so
3756007000-3756206000 ---p 00007000 fd:00 14226                          /lib64/librt-2.11.1.so
3756206000-3756207000 r--p 00006000 fd:00 14226                          /lib64/librt-2.11.1.so
3756207000-3756208000 rw-p 00007000 fd:00 14226                          /lib64/librt-2.11.1.so
3756400000-375641c000 r-xp 00000000 fd:00 3479                           /lib64/libselinux.so.1
375641c000-375661b000 ---p 0001c000 fd:00 3479                           /lib64/libselinux.so.1
375661b000-375661c000 r--p 0001b000 fd:00 3479                           /lib64/libselinux.so.1
375661c000-375661d000 rw-p 0001c000 fd:00 3479                           /lib64/libselinux.so.1
375661d000-375661e000 rw-p 00000000 00:00 0 
3756800000-37568e4000 r-xp 00000000 fd:00 13990                          /lib64/libglib-2.0.so.0.2200.3
37568e4000-3756ae4000 ---p 000e4000 fd:00 13990                          /lib64/libglib-2.0.so.0.2200.3
3756ae4000-3756ae5000 rw-p 000e4000 fd:00 13990                          /lib64/libglib-2.0.so.0.2200.3
3756ae5000-3756ae6000 rw-p 00000000 00:00 0 
3756c00000-3756c43000 r-xp 00000000 fd:00 82194                          /lib64/libgobject-2.0.so.0.2200.3
3756c43000-3756e43000 ---p 00043000 fd:00 82194                          /lib64/libgobject-2.0.so.0.2200.3
3756e43000-3756e45000 rw-p 00043000 fd:00 82194                          /lib64/libgobject-2.0.so.0.2200.3
3757000000-3757015000 r-xp 00000000 fd:00 82207                          /lib64/libresolv-2.11.1.so
3757015000-3757215000 ---p 00015000 fd:00 82207                          /lib64/libresolv-2.11.1.so
3757215000-3757216000 r--p 00015000 fd:00 82207                          /lib64/libresolv-2.11.1.so
3757216000-3757217000 rw-p 00016000 fd:00 82207                          /lib64/libresolv-2.11.1.so
3757217000-3757219000 rw-p 00000000 00:00 0 
3757400000-375743f000 r-xp 00000000 fd:00 81288                          /lib64/libdbus-1.so.3.4.0
375743f000-375763f000 ---p 0003f000 fd:00 81288                          /lib64/libdbus-1.so.3.4.0
375763f000-3757640000 r--p 0003f000 fd:00 81288                          /lib64/libdbus-1.so.3.4.0
3757640000-3757641000 rw-p 00040000 fd:00 81288                          /lib64/libdbus-1.so.3.4.0/usr/share/system-config-httpd/system-config-httpd: line 4: 20129 Aborted                 (core dumped) /usr/bin/python /usr/share/system-config-httpd/ApacheConf.py

I can confirm Robert Laverick's report. Same error.

Same error too, as comment 17.

***This may show up twice due to email delays, but I want to make sure it is here***
Phil,
  The issue is that the updated Alchemist.py file has use_pyalchemist set to False.  This causes it to not use the PyAlchemist file that you posted above and to use the old files that cause the issue.  Here is the diff output that shows the change I made.  It works after doing this:

--- Alchemist.py.1      2010-01-14 07:39:24.000000000 -0500
+++ Alchemist.py        2010-01-14 11:13:15.802182977 -0500
@@ -18,7 +18,7 @@
 ## along with this program; if not, write to the Free Software
 ## Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 
-use_pyalchemist = False
+use_pyalchemist = True
 
 if use_pyalchemist:
        from PyAlchemist import *

I can confirm it works with use_pyalchemist = True

Many thanks

There are a couple of new warnings reported in the calling window, but nothing serious:

# system-config-httpd
/usr/share/system-config-httpd/ApacheConf.py:55: Warning: g_set_prgname() called multiple times
  gnome.program_init(PROGNAME, "1.4.5")
/usr/share/system-config-httpd/ApacheConf.py:68: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
  xml = gtk.glade.XML (glade_file, domain=PROGNAME)
/usr/share/system-config-httpd/CheckList.py:12: DeprecationWarning: use gtk.TreeView
  CList.__init__ (self, 2)
/usr/share/system-config-httpd/ApacheConf.py:122: DeprecationWarning: use gtk.TreeView
  gtk.CList.__init__ (self, 3, [_("Error Code"), _("Behavior"), _("Location")])

The GUI that opens up seems to work just fine. Thanks a bunch.

Ah, ye, forgot to change the flag there. Fixed in the latest upload now by default.

But if this works fine with everyone i'll talk with Tim Waugh to make the transition away from the original alchemist work.

Thanks everyone for testing!

Regards, Phil

And ye, i know about the warnings, they come from the fact that the glade and UI stuff is basically still using very old and outdated widgets. Hopefully i'll find some time soon to fix those and rework the UI to use modern widgets, but no promises at the moment.

Thanks & regards, Phil

*** Bug 557675 has been marked as a duplicate of this bug. ***

i also have same kind of problem.

*** Bug 561460 has been marked as a duplicate of this bug. ***

*** Bug 565596 has been marked as a duplicate of this bug. ***

*** Bug 561601 has been marked as a duplicate of this bug. ***

*** Bug 554623 has been marked as a duplicate of this bug. ***

*** Bug 570049 has been marked as a duplicate of this bug. ***

Works fine for me, but use_pyalchemist is still false by default.
Thanks for the workaround.

How to reproduce
-----
1.Gnome=>System=>Administration=>HTTP
2.
3.

Hopefully i discovered the problem yesterday and the solution is perfectly working.
Thanks

Same as #22

Sorry for not updating here in a while, but i've just been insanely busy lately.

I'll try to get new packages built real soon now(tm), but it needed to be coordinated with the alchemist maintainer, but we're in sync now for a while so it shouldn't cause too much havok. :)

I'll update the bz as soon as new packages are built.

And again, sorry for the delay here, and thanks everyone for testing the changes!

Regards, Phil

Comment
-----
no idea.

Comment
-----
no idea.

Fix works perfect on F12 x64.

*** Bug 578792 has been marked as a duplicate of this bug. ***

*** Bug 573688 has been marked as a duplicate of this bug. ***

*** Bug 572251 has been marked as a duplicate of this bug. ***

Same result F13 Beta updated as of today. (1.4.6-1)

Same here as 43, system-config-httpd-1.4.6-1.fc13.noarch and just adding myself to the mail list.

*** Bug 584214 has been marked as a duplicate of this bug. ***

Alright, after such an insane delay i've finally had some time to fix up the last few tidbits for a release.

Rawhide build is done, can be found here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2196408

Please give it a whirl and let me know if it works for you. If so, then i'll go and do updates for F12 and F13 afterwards.

Again sorry for the insane delay here.

Thanks & regards, Phil

Phil,

Looks pretty good. I did find one minor error.
---------------------------
Click on  + Add
Select    * Listen to all addresses
Click on  OK
Error:    Inserted IP address is not valid
---------------------------
Simple work around: Use 0.0.0.0 as listen address.

Also three minor warnings in the calling window:

/usr/share/system-config-httpd/ApacheConf.py:68: GtkWarning: GtkSpinButton: setting an adjustment with non-zero page size is deprecated
  xml = gtk.glade.XML (glade_file, domain=PROGNAME)
/usr/share/system-config-httpd/CheckList.py:12: DeprecationWarning: use gtk.TreeView
  CList.__init__ (self, 2)
/usr/share/system-config-httpd/ApacheConf.py:122: DeprecationWarning: use gtk.TreeView
  gtk.CList.__init__ (self, 3, [_("Error Code"), _("Behavior"), _("Location")])

--Doc

Ok, fixed the first one, easy fix.

The warnings in the console come from the fact that i haven't had time yet to properly convert s-c-h to gnome-2, so thats expected. Not sure when (if) i find the time to do so anytime soon, but you never know. :)

I'll get s-c-h-1.5.1 built in a few minutes with the fix for the IP dialog.

Thanks & regards, Phil

Build just finished:

http://kojipkgs.fedoraproject.org/packages/system-config-httpd/1.5.1/1.fc14/noarch/system-config-httpd-1.5.1-1.fc14.noarch.rpm

That should fix the ip address problem.

Phil,

That did it. Looks ready to go. Thanks very much.

--Doc

(BTW, I'm testing on 64-bit F13beta w/updates.)

Working here on fedora 12.

Thanks for your efforts.  I know in the big picture this is a small thing, cli option is fine, but this is definitely is a nice to have.

can you push that as an update for fedora 13?

system-config-httpd-1.5.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/system-config-httpd-1.5.1-1.fc13

system-config-httpd-1.5.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/system-config-httpd-1.5.1-1.fc12

Alright, seems it works for most folks, so i'll go ahead and do proper builds
for F12 and F13 today.

Builds and update requests are done. Thanks again everyone for being so patient!

Regards, Phil

*** Bug 586666 has been marked as a duplicate of this bug. ***

*** Bug 586084 has been marked as a duplicate of this bug. ***

*** Bug 583174 has been marked as a duplicate of this bug. ***

*** Bug 544191 has been marked as a duplicate of this bug. ***

*** Bug 544208 has been marked as a duplicate of this bug. ***

system-config-httpd-1.5.1-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-httpd'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-httpd-1.5.1-1.fc12

system-config-httpd-1.5.1-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

system-config-httpd-1.5.1-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.