Bug 537452

Summary:	Review Request: eclipse-emf-validation - Verify the integrity of EMF models
Product:	[Fedora] Fedora	Reporter:	Mat Booth <mat.booth>
Component:	Package Review	Assignee:	Lubomir Rintel <lkundrak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, lkundrak, notting
Target Milestone:	---	Flags:	lkundrak: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-12-01 21:23:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	536684
Bug Blocks:	537454

Description Mat Booth 2009-11-13 17:12:06 UTC

This package depends eclipse-mdt-ocl, whose review request is bug #536684.

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-validation.spec
SRPM URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-validation-1.3.1-1.fc12.src.rpm

Description:
The validation component provides the following capabilities.

 * Constraint Definition - Provides API for defining constraints for any EMF
   meta-model (batch and live constraints).
 * Customizable model traversal algorithms - Extensibility API to support
   meta-models that require custom strategies for model traversal.
 * Constraint parsing for languages - Provides support for parsing the content
   of constraint elements defined in specific languages. The validation
   framework provides support for two languages: Java and OCL.
 * Configurable constraint bindings to application contexts - API support to
   define "client contexts" that describe the objects that need to be validated
   and to bind them to constraints that need to be enforced on these objects.
 * Validation listeners - Support for listening to validation events.

Comment 1 Lubomir Rintel 2009-11-21 19:28:02 UTC

* Package name and version are in accordance with packaging guidelines
* SPEC file clean, legible and well-commented
* License tag correct, license packaged as %doc
* RPMLint happy
  * a couple of warnings spelling errors in fc13, all of them false positives
* Filelist okay, for directories it uses and does now it depends on packages that provide them
* Provides/Require list ok
(mock build did not finish yet)

Objections:

1.) Why do you check stuff out from CVS?

2.) Please don't pretty-format the Description, please use complete sentences. It does not always look well in package management front-ends.

Comment 2 Lubomir Rintel 2009-11-21 23:51:08 UTC

* mock build succeeded

Comment 3 Lubomir Rintel 2009-11-22 13:35:24 UTC

1.) is answered in bug #536683.
Please re-format the description before importing to CVS!

APPROVED

Comment 4 Mat Booth 2009-11-24 10:34:48 UTC

(In reply to comment #3)
> 1.) is answered in bug #536683.
> Please re-format the description before importing to CVS!
> 


Done:

Spec URL: http://mbooth.fedorapeople.org/reviews/eclipse-emf-validation.spec
SRPM URL:
http://mbooth.fedorapeople.org/reviews/eclipse-emf-validation-1.3.1-2.fc12.src.rpm


> APPROVED  


New Package CVS Request
=======================
Package Name: eclipse-emf-validation
Short Description: Verify the integrity of EMF models
Owners: mbooth
Branches: F-12

Comment 5 Mat Booth 2009-11-24 10:40:15 UTC

Apologies, I rebuilt the SRPM on a F-10 box, so please s/fc12/fc10/ in my last comment. Also forgot to set the cvs flag... d'oh.

Comment 6 Kevin Fenzi 2009-11-27 05:30:27 UTC

cvs done.

Comment 7 Mat Booth 2009-12-01 21:23:20 UTC

Built successfully in rawhide, closing.