Bug 584910

+++ This bug was initially created as a clone of Bug #527701 +++

Created an attachment (id=363962)
init script with both problems fixed

Description of problem:
[root@ejs-desktop ~]# /etc/rc.d/init.d/microcode_ctl start
/etc/rc.d/init.d/microcode_ctl: line 52: syntax error near unexpected token `}'
/etc/rc.d/init.d/microcode_ctl: line 52: `}'

Also, on fixing the syntax error, it doesn't print the "[  OK  ]" or "[FAILED]" anymore.

Version-Release number of selected component (if applicable):
microcode_ctl-1.17-1.55.fc12

How reproducible:
Always.

Steps to Reproduce:
1. (as root) service microcode_ctl start
2.
3.
  
Actual results:
Syntax error.

Expected results:
Applying Intel CPU microcode update:                       [  OK  ]

Additional info:
It looks like bash doesn't allow empty functions. The empty stop function and references to it could be removed.

--- Additional comment from fedora-triage-list on 2009-11-16 08:21:32 EST ---


This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

--- Additional comment from ejs1920.uk on 2009-11-23 15:45:35 EST ---

microcode_ctl-1.17-1.55.fc12 isn't in Fedora 12 or even rawhide, only koji.

--- Additional comment from xose.vazquez on 2009-12-07 11:08:15 EST ---


microcode_ctl-1.17-1.56.fc12 from updates-testing is still broken:

# /etc/init.d/microcode_ctl start
/etc/init.d/microcode_ctl: line 59: syntax error near unexpected token `}'
/etc/init.d/microcode_ctl: line 59: `}'

--- Additional comment from frankly3d on 2009-12-15 06:21:39 EST ---

Seems to be now fixed with:
http://koji.fedoraproject.org/koji/buildinfo?buildID=144680

--- Additional comment from ejs1920.uk on 2009-12-16 16:21:29 EST ---

Created an attachment (id=378853)
Fix init script output

There's no syntax error in microcode_ctl-1.17-1.57.fc12, but the init script still doesn't output the [  OK  ] or [FAILED], the line that is printed is with "echo -n" so the message from whatever starts next will be printed on the same line.

Also the init script's "Usage:" line doesn't print out correctly due to a stray $ (the first one).

--- Additional comment from ejs1920.uk on 2009-12-16 16:38:41 EST ---

Re-opening.

--- Additional comment from redhat-bugzilla on 2009-12-26 11:02:48 EST ---

Still busted. Note, the initscript misses a "\n" as well, it's just 2 lines
and not three as bugzilla will make it. The third line with the prompt is
directly appended to the second.

[root@tux ~]# /etc/init.d/microcode_ctl start 
Applying Intel CPU microcode update: Applying Intel CPU microcode update: [root@tux ~]#

--- Additional comment from ppokorny on 2010-04-22 13:12:20 EDT ---

Also an issue with Red Hat 6 beta.