RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 584910 - microcode_ctl init script syntax error
Summary: microcode_ctl init script syntax error
Keywords:
Status: CLOSED DUPLICATE of bug 552246
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: microcode_ctl
Version: 6.0
Hardware: All
OS: Linux
low
medium
Target Milestone: rc
: ---
Assignee: Anton Arapov
QA Contact: qe-baseos-daemons
URL:
Whiteboard:
Depends On: 527701
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-22 17:26 UTC by Orion Poplawski
Modified: 2014-06-18 08:02 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 527701
Environment:
Last Closed: 2010-04-23 20:02:51 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
New version of script that should fix AMD OK/FAILURE problem (1.41 KB, text/plain)
2010-04-22 19:08 UTC, Philip Pokorny
no flags Details

Description Orion Poplawski 2010-04-22 17:26:08 UTC
+++ This bug was initially created as a clone of Bug #527701 +++

Created an attachment (id=363962)
init script with both problems fixed

Description of problem:
[root@ejs-desktop ~]# /etc/rc.d/init.d/microcode_ctl start
/etc/rc.d/init.d/microcode_ctl: line 52: syntax error near unexpected token `}'
/etc/rc.d/init.d/microcode_ctl: line 52: `}'

Also, on fixing the syntax error, it doesn't print the "[  OK  ]" or "[FAILED]" anymore.

Version-Release number of selected component (if applicable):
microcode_ctl-1.17-1.55.fc12

How reproducible:
Always.

Steps to Reproduce:
1. (as root) service microcode_ctl start
2.
3.
  
Actual results:
Syntax error.

Expected results:
Applying Intel CPU microcode update:                       [  OK  ]

Additional info:
It looks like bash doesn't allow empty functions. The empty stop function and references to it could be removed.

--- Additional comment from fedora-triage-list on 2009-11-16 08:21:32 EST ---


This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle.
Changing version to '12'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

--- Additional comment from ejs1920.uk on 2009-11-23 15:45:35 EST ---

microcode_ctl-1.17-1.55.fc12 isn't in Fedora 12 or even rawhide, only koji.

--- Additional comment from xose.vazquez on 2009-12-07 11:08:15 EST ---


microcode_ctl-1.17-1.56.fc12 from updates-testing is still broken:

# /etc/init.d/microcode_ctl start
/etc/init.d/microcode_ctl: line 59: syntax error near unexpected token `}'
/etc/init.d/microcode_ctl: line 59: `}'

--- Additional comment from frankly3d on 2009-12-15 06:21:39 EST ---

Seems to be now fixed with:
http://koji.fedoraproject.org/koji/buildinfo?buildID=144680

--- Additional comment from ejs1920.uk on 2009-12-16 16:21:29 EST ---

Created an attachment (id=378853)
Fix init script output

There's no syntax error in microcode_ctl-1.17-1.57.fc12, but the init script still doesn't output the [  OK  ] or [FAILED], the line that is printed is with "echo -n" so the message from whatever starts next will be printed on the same line.

Also the init script's "Usage:" line doesn't print out correctly due to a stray $ (the first one).

--- Additional comment from ejs1920.uk on 2009-12-16 16:38:41 EST ---

Re-opening.

--- Additional comment from redhat-bugzilla on 2009-12-26 11:02:48 EST ---

Still busted. Note, the initscript misses a "\n" as well, it's just 2 lines
and not three as bugzilla will make it. The third line with the prompt is
directly appended to the second.

[root@tux ~]# /etc/init.d/microcode_ctl start 
Applying Intel CPU microcode update: Applying Intel CPU microcode update: [root@tux ~]#

--- Additional comment from ppokorny on 2010-04-22 13:12:20 EDT ---

Also an issue with Red Hat 6 beta.

Comment 2 Philip Pokorny 2010-04-22 19:03:08 UTC
The attachment to the parent cloned bug has an additional issue that AMD microcode updates won't print OK/FAILURE due to the script logic.

Comment 3 Philip Pokorny 2010-04-22 19:08:17 UTC
Created attachment 408423 [details]
New version of script that should fix AMD OK/FAILURE problem

Re-arranged the if/then/else blocks so that the OK/FAILURE always prints

Comment 4 RHEL Program Management 2010-04-22 20:13:38 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 5 Bill Nottingham 2010-04-23 20:02:51 UTC

*** This bug has been marked as a duplicate of bug 552246 ***


Note You need to log in before you can comment on or make changes to this bug.