Bug 633931

Summary: Last tigervnc upgrade broke Caps-Lock
Product: [Fedora] Fedora Reporter: Alfredo Ferrari <alfredo.maria.ferrari>
Component: tigervncAssignee: Adam Tkac <atkac>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 13CC: atkac, bojan, kc8ldo, mdf1978, orion, ovasik
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: tigervnc-1.0.90-0.15.20100420svn4030.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-10-21 06:02:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
starce of "service vncserver start"
none
vnc configuration file
none
output of "service vncserver start" when set -x is added
none
diff between old and new /etc/init.d/vncserver none

Description Alfredo Ferrari 2010-09-14 17:11:36 UTC 
Description of problem:
Caps-lock does no longer work after upgrading to the last version

Version-Release number of selected component (if applicable):
tigervnc-server-1.0.90-0.13.20100420svn4030.fc13.

How reproducible:
Always, both on i686 and x86_64

Steps to Reproduce:
1. start a tigervnc server
2. use vncviewer to connect to that server
3. Set caps-lock and type whichever alphabetic character
  
Actual results:
Characters are never capitalized

Expected results:
Characters should be capitalized

Additional info:
It worked correctly until version tigervnc-1.0.90-0.12.20100420svn4030.fc13 included. Downgrading to tigervnc-1.0.90-0.12.20100420svn4030.fc13 restore the Caps-lock functionality
Comment 1 Adam Tkac 2010-09-15 10:43:27 UTC 
*** Bug 632076 has been marked as a duplicate of this bug. ***
Comment 2 Orion Poplawski 2010-09-15 21:09:13 UTC 
*** Bug 634347 has been marked as a duplicate of this bug. ***
Comment 3 Fedora Update System 2010-09-16 13:54:16 UTC 
tigervnc-1.0.90-0.14.20100420svn4030.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/tigervnc-1.0.90-0.14.20100420svn4030.fc13
Comment 4 Alfredo Ferrari 2010-09-16 17:26:50 UTC 
Created attachment 447806 [details]
starce of "service vncserver start"
Comment 5 Alfredo Ferrari 2010-09-16 17:32:09 UTC 
Created attachment 447807 [details]
vnc configuration file
Comment 6 Alfredo Ferrari 2010-09-16 17:32:46 UTC 
Stop it!! The server does not even start using tigervnc-1.0.90-0.14.20100420svn4030.fc13. On both i686 and x86_64 typing

service vncserver start

it fails with:

[root@pcalfr alfredo]# service vncserver start
Starting VNC server: 1:alfredo Ambiguous output redirect.
                                                           [FAILED]

I attach the full strace of service vncserver start as well as my config file
Comment 7 Adam Tkac 2010-09-20 07:14:32 UTC 
(In reply to comment #6)
> Stop it!! The server does not even start using
> tigervnc-1.0.90-0.14.20100420svn4030.fc13. On both i686 and x86_64 typing
> 
> service vncserver start
> 
> it fails with:
> 
> [root@pcalfr alfredo]# service vncserver start
> Starting VNC server: 1:alfredo Ambiguous output redirect.
>                                                            [FAILED]
> 
> I attach the full strace of service vncserver start as well as my config file

I'm not able to reproduce this issue. Would it be possible to manually add "set -x" to the /etc/init.d/vncserver file, run `service vncserver start` again and attach output here, please?

$ cat /etc/init.d/vncserver
#!/bin/bash
...
. /etc/init.d/functions

set -x

[ -r /etc/sysconfig/vncservers ] && . /etc/sysconfig/vncservers
...
Comment 8 Alfredo Ferrari 2010-09-20 10:57:29 UTC 
Done. I am going to attach the output (vnc.out) in a moment. I also made a diff of the /etc/init.d/vncserver scripts, old and new, and clearly the only changed line (see diff.out attached as well in a moment) is the culprit. using the "old"
/etc/init.d/vncserver with tigervnc-1.0.90-0.14.20100420svn4030.fc13, the server starts with no issue and a quick check seems to confirm that everything is fine (at least caps Lock is surely fine)
Comment 9 Alfredo Ferrari 2010-09-20 10:58:50 UTC 
Created attachment 448428 [details]
output of "service vncserver start" when set -x is added
Comment 10 Alfredo Ferrari 2010-09-20 10:59:33 UTC 
Created attachment 448429 [details]
diff between old and new /etc/init.d/vncserver
Comment 11 Adam Tkac 2010-09-20 11:51:49 UTC 
(In reply to comment #9)
> Created attachment 448428 [details]
> output of "service vncserver start" when set -x is added

I think I've figured what's broken. Which shell is default for "alfredo" user?

When you add "-s /bin/bash" parameter to the "runuser" command in the /etc/init.d/vncserver script (runuser -s /bin/bash -l ${USER} -c "...") does it solve your issue?
Comment 12 Alfredo Ferrari 2010-09-21 06:07:28 UTC 
... tcsh and the answer is yes, with -s /bin/bash the server starts with no problem.

Thanks!
Comment 13 Alfredo Ferrari 2010-09-21 06:09:36 UTC 
.... oops... too quick to answer! Yes the server starts with no problem, but then the user is locked into bash, which obviously is very uncomfortable (all intializations, scripts etc broken...) to say the least
Comment 14 Adam Tkac 2010-09-21 08:39:46 UTC 
(In reply to comment #13)
> .... oops... too quick to answer! Yes the server starts with no problem, but
> then the user is locked into bash, which obviously is very uncomfortable (all
> intializations, scripts etc broken...) to say the least

tigervnc-1.0.90-0.15.20100420svn4030.fc13 should be fine, I've pushed it to -testing repo (http://admin.fedoraproject.org/updates/tigervnc-1.0.90-0.15.20100420svn4030.fc13).
Comment 15 Fedora Update System 2010-09-22 00:35:54 UTC 
tigervnc-1.0.90-0.15.20100420svn4030.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tigervnc'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/tigervnc-1.0.90-0.15.20100420svn4030.fc13
Comment 16 Leland C. Scott 2010-09-22 21:39:08 UTC 
I just installed the same package (0.15) on my 32 bit F-13 system and I can
confirm the caps-lock still doesn't work for me.

(In reply to comment #15)
> tigervnc-1.0.90-0.15.20100420svn4030.fc13 has been pushed to the Fedora 13
> testing repository.  If problems still persist, please make note of it in this
> bug report.
>  If you want to test the update, you can install it with 
>  su -c 'yum --enablerepo=updates-testing update tigervnc'.  You can provide
> feedback for this update here:
> https://admin.fedoraproject.org/updates/tigervnc-1.0.90-0.15.20100420svn4030.fc13
Comment 17 Orion Poplawski 2010-09-22 21:58:13 UTC 
0.15 works fixes caps lock for me.
Comment 18 Leland C. Scott 2010-09-22 22:42:18 UTC 
Looks like I didn't update the server, just the client. It works now for me too after updating the "tiger-server" package. The instruction below only did the client I noticed after double checking.

(In reply to comment #16)
> I just installed the same package (0.15) on my 32 bit F-13 system and I can
> confirm the caps-lock still doesn't work for me.
> (In reply to comment #15)
> > tigervnc-1.0.90-0.15.20100420svn4030.fc13 has been pushed to the Fedora 13
> > testing repository.  If problems still persist, please make note of it in this
> > bug report.
> >  If you want to test the update, you can install it with 
> >  su -c 'yum --enablerepo=updates-testing update tigervnc'.  You can provide
> > feedback for this update here:
> > https://admin.fedoraproject.org/updates/tigervnc-1.0.90-0.15.20100420svn4030.fc13
Comment 19 Fedora Update System 2010-10-21 06:01:44 UTC 
tigervnc-1.0.90-0.15.20100420svn4030.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.