Bug 637939
| Summary: | Review Request: rubygem-gdk_pixbuf2 - Ruby binding of GdkPixbuf-2.x | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mamoru TASAKA <mtasaka> |
| Component: | Package Review | Assignee: | Michal Fojtik <mfojtik> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mfojtik, notting |
| Target Milestone: | --- | Flags: | mfojtik:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-08 17:40:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 635302, 637448 | ||
| Bug Blocks: | 639098, 639636, 639638 | ||
|
Description
Mamoru TASAKA
2010-09-27 19:39:37 UTC
http://mtasaka.fedorapeople.org/Review_request/rubygem-gdk_pixbuf2/rubygem-gdk_pixbuf2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-gdk_pixbuf2/rubygem-gdk_pixbuf2-0.90.2-4.fc.src.rpm * Fri Oct 1 2010 Mamoru Tasaka <mtasaka.u-tokyo.ac.jp> - 0.90.2-4 - Use formally released gem file ping? (Note: 0.90.3 is released, however for now please review this 0.90.2 version) http://mtasaka.fedorapeople.org/Review_request/rubygem-gdk_pixbuf2/rubygem-gdk_pixbuf2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-gdk_pixbuf2/rubygem-gdk_pixbuf2-0.90.4-2.fc.src.rpm * Sun Oct 24 2010 Mamoru Taska <mtasaka.u-tokyo.ac.jp> - 0.90.4-2 - 0.90.4 * Sun Oct 24 2010 Mamoru Taska <mtasaka.u-tokyo.ac.jp> - 0.90.3-2 - 0.90.3 http://mtasaka.fedorapeople.org/Review_request/rubygem-gdk_pixbuf2/rubygem-gdk_pixbuf2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-gdk_pixbuf2/rubygem-gdk_pixbuf2-0.90.5-2.fc.src.rpm * Sun Oct 31 2010 Mamoru Taska <mtasaka.u-tokyo.ac.jp> - 0.90.5-2 - 0.90.5 - Move C extension so that "require %%gemname" works correctly Michal, would you review this? This bug currently blocks all other ruby-gnome2 related packages. I'm really sorry for the delay, as usually, this package looks perfectly sane for me:
* Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification.
[OK]
* The Source of the package must be the full URL to the released Gem archive; th version of the package must be the Gem's version
[!] Please correct URL to: http://rubygems.org/downloads/%{gemname}-%{version}.gem
The package must have a Requires and a BuildRequires on rubygems
[OK]
For every dependency on a Gem named gemdep, the package must contain a Requires on rubygem(%{gemdep}) with the same version constraints as the Gem
[OK]
The %prep and %build sections of the specfile should be empty.
[OK] -> They are not empty, but it's OK for binary extensions
The Gem must be installed into %{gemdir} defined as
%global gemdir %(ruby -rubygems -e 'puts Gem::dir' 2>/dev/null)
[OK]
Architecture-specific content must not be installed into %{gemdir}
[OK]
If the Gem contains binary content (e.g., for a database driver), it must be marked as architecture specific, and all architecture specific content must be moved from the %{gemdir} to the [#ruby_sitearch %{ruby_sitearch} directory] during %install
[OK]
Other things looks good as well. REVIEW+
(Please correct that URL before importing this gem into git)
Thank you! Would you change fedora-review flag instead of fedora-cvs flag? (I can do it, however I guess I should not do it) (In reply to comment #7) > Thank you! > Would you change fedora-review flag instead of fedora-cvs flag? > (I can do it, however I guess I should not do it) Oh crap, sorry for that. Just too much work nowadays ;-) Thank you again! New Package SCM Request ======================= Package Name: rubygem-gdk_pixbuf2 Short Description: Ruby binding of GdkPixbuf-2.x Owners: mtasaka Branches: f13 f14 Git done (by process-git-requests). Closing. Thank you for reviewing and SCM procedure. |