| Summary: | Review Request: game-music-emu - Video game music file emulation/playback library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karel Volný <kvolny> |
| Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | BobLfoot, bugs.michael, fedora-package-review, i, notting |
| Target Milestone: | --- | Flags: | bugs.michael:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://code.google.com/p/game-music-emu/ | ||
| Whiteboard: | |||
| Fixed In Version: | game-music-emu-0.5.5-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-17 01:14:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 677280, 989325 | ||
|
Description
Karel Volný
2011-06-24 15:25:22 UTC
* > Summary: A collection of video game music file emulators Since summaries starting with "A ..." still make a bad reading when displayed in package installers and Anaconda, I suggest using the summary from the project's web site: Summary: Video game music file emulation/playback library * I agree with the comments on the rpmlint warnings. :) * The demo player and WAV writer source code use a different license, an "MIT" variant. Please consider that when importing the package. * gme_player (x86_64) works with a couple of test files I have here. APPROVED (In reply to comment #1) > * > Summary: A collection of video game music file emulators > > Since summaries starting with "A ..." still make a bad reading when displayed > in package installers and Anaconda, I suggest using the summary from the > project's web site: > > Summary: Video game music file emulation/playback library ah, I've missed that line - I've used what's on "Project Home" below > * I agree with the comments on the rpmlint warnings. :) > > * The demo player and WAV writer source code use a different license, an "MIT" > variant. Please consider that when importing the package. good catch ... I'm not much into the legal stuff, I just took what's written on the project page I've e-mailed the author about this, for now I'd just silently ignore this (LGPL is more restrictive, so anyone obeying LGPL also obeys the real license of the affected files) > * gme_player (x86_64) works with a couple of test files I have here. > > APPROVED cool, thanks New Package SCM Request ======================= Package Name: game-music-emu Short Description: Video game music file emulation/playback library Owners: kvolny Branches: f15 el6 InitialCC: Git done (by process-git-requests). Added f16 branch. game-music-emu-0.5.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/game-music-emu-0.5.5-1.fc15 game-music-emu-0.5.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/game-music-emu-0.5.5-1.fc16 game-music-emu-0.5.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/game-music-emu-0.5.5-1.el6 (In reply to comment #2) > (In reply to comment #1) > > * The demo player and WAV writer source code use a different license, an > > "MIT" variant. Please consider that when importing the package. > > I've e-mailed the author about this, and the answer is that MIT was really intended and "I'm leaning towards CC0 Public Domain" for now, I've put "License: MIT" into the player subpackage (In reply to comment #4) > Git done (by process-git-requests). > > Added f16 branch. thanks um, I've missed that we already have f16, I should look into calendar more often :-( game-music-emu-0.5.5-1.fc16 has been pushed to the Fedora 16 testing repository. game-music-emu-0.5.5-1.fc15 has been pushed to the Fedora 15 stable repository. game-music-emu-0.5.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository. game-music-emu-0.5.5-1.fc16 has been pushed to the Fedora 16 stable repository. Oh damn.... I just found this library has been keeper's in Fedora for years, I really want to ask this review's reporter, what were you thinking about when mainframe this library like this? Only 2 solution now. 1. I retire my libgme package. 2. You retire this package and I add obsolete tag. I'm really confused. Mainframe = naming Sorry for the typo, I'm outside. *** Bug 989325 has been marked as a duplicate of this bug. *** oops, I've missed this ... (In reply to Christopher Meng from comment #13) > I just found this library has been keeper's in Fedora for years, I really > want to ask this review's reporter, what were you thinking about when > _naming_ this library like this? a clue could be found in bug 989325 ... I believe this name is consistent with naming guidelines > Only 2 solution now. > 1. I retire my libgme package. I see this was done ... what about becoming a co-maintainer? *** Bug 1123241 has been marked as a duplicate of this bug. *** Package Change Request ====================== Package Name: game-music-emu New Branches: epel7 Owners: moezroy kvolny Git done (by process-git-requests). |