Spec URL: http://kvolny.fedorapeople.org/game-music-emu.spec SRPM URL: http://kvolny.fedorapeople.org/game-music-emu-0.5.5-1.fc15.src.rpm Description: Game_Music_Emu is a collection of video game music file emulators that support the following formats and systems: * AY ZX Spectrum/Amstrad CPC * GBS Nintendo Game Boy * GYM Sega Genesis/Mega Drive * HES NEC TurboGrafx-16/PC Engine * KSS MSX Home Computer/other Z80 systems (doesn't support FM sound) * NSF/NSFE Nintendo NES/Famicom (with VRC 6, Namco 106, and FME-7 sound) * SAP Atari systems using POKEY sound chip * SPC Super Nintendo/Super Famicom * VGM/VGZ Sega Master System/Mark III, Sega Genesis/Mega Drive,BBC Micro I need this library as a dependency of qmmp plugin for playing those formats. The package builds fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=3159034 $ rpmlint game-music-emu.spec game-music-emu.spec: W: invalid-url Source0: http://game-music-emu.googlecode.com/files/game-music-emu-0.5.5.tbz2 HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. It seems there is something rotten with rpmlint as I can fetch the file with wget without any problems ... $ rpmlint game-music-emu-0.5.5-1.fc15.src.rpm game-music-emu.src: W: invalid-url Source0: http://game-music-emu.googlecode.com/files/game-music-emu-0.5.5.tbz2 HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 1 warnings. the same as above $ rpmlint game-music-emu-0.5.5-1.fc15.x86_64.rpm game-music-emu.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/game-music-emu-0.5.5/license.txt game-music-emu.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/game-music-emu-0.5.5/readme.txt game-music-emu.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/game-music-emu-0.5.5/changes.txt 1 packages and 0 specfiles checked; 0 errors, 3 warnings. - this comes from upstream, not sure what is this test useful for, virtually everything handles MS-style CRLF without any problem $ rpmlint game-music-emu-devel-0.5.5-1.fc15.x86_64.rpm game-music-emu-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/game-music-emu-devel-0.5.5/design.txt game-music-emu-devel.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/game-music-emu-devel-0.5.5/gme.txt 1 packages and 0 specfiles checked; 0 errors, 2 warnings. the same as above $ rpmlint game-music-emu-player-0.5.5-1.fc15.x86_64.rpm game-music-emu-player.x86_64: W: no-documentation game-music-emu-player.x86_64: W: no-manual-page-for-binary gme_player 1 packages and 0 specfiles checked; 0 errors, 2 warnings. The documentation is included within the base package which is a dependency for the player. The manpage is not provided by upstream, and I do not see any point in doing so as the player is useful only for testing purposes (which is the reason I've put it in subpackage that doesn't need to be installed). $ rpmlint game-music-emu-debuginfo-0.5.5-1.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Note that the patches to buildsystem are included in spec rather than separate patch files due to usage of macros.
* > Summary: A collection of video game music file emulators Since summaries starting with "A ..." still make a bad reading when displayed in package installers and Anaconda, I suggest using the summary from the project's web site: Summary: Video game music file emulation/playback library * I agree with the comments on the rpmlint warnings. :) * The demo player and WAV writer source code use a different license, an "MIT" variant. Please consider that when importing the package. * gme_player (x86_64) works with a couple of test files I have here. APPROVED
(In reply to comment #1) > * > Summary: A collection of video game music file emulators > > Since summaries starting with "A ..." still make a bad reading when displayed > in package installers and Anaconda, I suggest using the summary from the > project's web site: > > Summary: Video game music file emulation/playback library ah, I've missed that line - I've used what's on "Project Home" below > * I agree with the comments on the rpmlint warnings. :) > > * The demo player and WAV writer source code use a different license, an "MIT" > variant. Please consider that when importing the package. good catch ... I'm not much into the legal stuff, I just took what's written on the project page I've e-mailed the author about this, for now I'd just silently ignore this (LGPL is more restrictive, so anyone obeying LGPL also obeys the real license of the affected files) > * gme_player (x86_64) works with a couple of test files I have here. > > APPROVED cool, thanks
New Package SCM Request ======================= Package Name: game-music-emu Short Description: Video game music file emulation/playback library Owners: kvolny Branches: f15 el6 InitialCC:
Git done (by process-git-requests). Added f16 branch.
game-music-emu-0.5.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/game-music-emu-0.5.5-1.fc15
game-music-emu-0.5.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/game-music-emu-0.5.5-1.fc16
game-music-emu-0.5.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/game-music-emu-0.5.5-1.el6
(In reply to comment #2) > (In reply to comment #1) > > * The demo player and WAV writer source code use a different license, an > > "MIT" variant. Please consider that when importing the package. > > I've e-mailed the author about this, and the answer is that MIT was really intended and "I'm leaning towards CC0 Public Domain" for now, I've put "License: MIT" into the player subpackage (In reply to comment #4) > Git done (by process-git-requests). > > Added f16 branch. thanks um, I've missed that we already have f16, I should look into calendar more often :-(
game-music-emu-0.5.5-1.fc16 has been pushed to the Fedora 16 testing repository.
game-music-emu-0.5.5-1.fc15 has been pushed to the Fedora 15 stable repository.
game-music-emu-0.5.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
game-music-emu-0.5.5-1.fc16 has been pushed to the Fedora 16 stable repository.
Oh damn.... I just found this library has been keeper's in Fedora for years, I really want to ask this review's reporter, what were you thinking about when mainframe this library like this? Only 2 solution now. 1. I retire my libgme package. 2. You retire this package and I add obsolete tag. I'm really confused.
Mainframe = naming Sorry for the typo, I'm outside.
*** Bug 989325 has been marked as a duplicate of this bug. ***
oops, I've missed this ... (In reply to Christopher Meng from comment #13) > I just found this library has been keeper's in Fedora for years, I really > want to ask this review's reporter, what were you thinking about when > _naming_ this library like this? a clue could be found in bug 989325 ... I believe this name is consistent with naming guidelines > Only 2 solution now. > 1. I retire my libgme package. I see this was done ... what about becoming a co-maintainer?
*** Bug 1123241 has been marked as a duplicate of this bug. ***
Package Change Request ====================== Package Name: game-music-emu New Branches: epel7 Owners: moezroy kvolny
Git done (by process-git-requests).