Bug 785449 (Horde_Browser)

Summary: Review Request: php-horde-Horde-Browser - Horde Browser API
Product: [Fedora] Fedora Reporter: Nick Bebout <nb>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora, notting, package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-20 22:00:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 785424, 785436, 785439    
Bug Blocks: 785495, 894570    
Attachments:
Description Flags
phpci.log
none
php-horde-Horde-Browser-review.txt none

Description Nick Bebout 2012-01-29 01:10:53 UTC
Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser.spec
SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser-1.0.5-1.fc16.src.rpm
Description: The Horde_Browser class provides an API for getting information about the current user's browser and its capabilities.

Comment 2 Shawn Iwinski 2012-07-04 23:28:05 UTC
I will review this package

Comment 3 Nick Bebout 2012-07-19 16:47:15 UTC
I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.

Comment 4 Shawn Iwinski 2012-07-22 04:48:55 UTC
After a quick review:

[MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml

Comment 6 Shawn Iwinski 2012-12-19 18:36:23 UTC
Created attachment 666283 [details]
phpci.log

Comment 7 Shawn Iwinski 2012-12-19 18:36:47 UTC
Created attachment 666286 [details]
php-horde-Horde-Browser-review.txt

Comment 8 Shawn Iwinski 2012-12-19 18:40:45 UTC
===== COULD items =====
* Require php-pcre
* "s/pear.horde.org/%{pear_channel}/" and add "%global pear_channel pear.horde.org"


No blockers.


===== APPROVED =====

Comment 9 Nick Bebout 2012-12-19 21:10:20 UTC
New Package SCM Request
=======================
Package Name: php-horde-Horde-Browser
Short Description: The Horde_Browser class provides an API for getting information about the current user's browser and its capabilities
Owners: nb
Branches: f17 f18 el6
InitialCC: remi

Comment 10 Gwyn Ciesla 2012-12-20 11:45:37 UTC
Git done (by process-git-requests).