Bug 785449 (Horde_Browser)
| Summary: | Review Request: php-horde-Horde-Browser - Horde Browser API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, notting, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-12-20 22:00:38 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 785424, 785436, 785439 | ||||||||
| Bug Blocks: | 785495, 894570 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nick Bebout
2012-01-29 01:10:53 UTC
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser-1.0.7-1.fc16.src.rpm I will review this package I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package. After a quick review: [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Browser-2.0.2-1.fc17.src.rpm Created attachment 666283 [details]
phpci.log
Created attachment 666286 [details]
php-horde-Horde-Browser-review.txt
===== COULD items =====
* Require php-pcre
* "s/pear.horde.org/%{pear_channel}/" and add "%global pear_channel pear.horde.org"
No blockers.
===== APPROVED =====
New Package SCM Request ======================= Package Name: php-horde-Horde-Browser Short Description: The Horde_Browser class provides an API for getting information about the current user's browser and its capabilities Owners: nb Branches: f17 f18 el6 InitialCC: remi Git done (by process-git-requests). |