Bug 894570 (Horde_Editor) - Review Request: php-horde-Horde-Editor - Horde Editor API
Summary: Review Request: php-horde-Horde-Editor - Horde Editor API
Keywords:
Status: CLOSED ERRATA
Alias: Horde_Editor
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: Horde_Exception Horde_Browser Horde_Serialize 873408
Blocks: Horde_Core
TreeView+ depends on / blocked
 
Reported: 2013-01-12 09:05 UTC by Remi Collet
Modified: 2013-03-09 19:22 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-02-28 07:06:14 UTC
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
php-horde-Horde-Editor-review.txt (7.22 KB, text/plain)
2013-02-04 20:06 UTC, Shawn Iwinski
no flags Details
phpci.log (8.08 KB, text/x-log)
2013-02-04 20:07 UTC, Shawn Iwinski
no flags Details

Description Remi Collet 2013-01-12 09:05:05 UTC
Spec URL: https://raw.github.com/remicollet/remirepo/bc4bc2649ebe72a42b01fed7e5df16fad8fba7a1/php/horde/php-horde-Horde-Editor/php-horde-Horde-Editor.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Editor-2.0.1-1.remi.src.rpm
Description: 
The Horde_Editor package provides an API to generate the code necessary for
embedding javascript RTE editors in a web page.

Fedora Account System Username: remi

Comment 2 Shawn Iwinski 2013-02-04 20:06:37 UTC
Created attachment 692994 [details]
php-horde-Horde-Editor-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 894570 --mock-config fedora-rawhide-x86_64

Comment 3 Shawn Iwinski 2013-02-04 20:07:09 UTC
Created attachment 692995 [details]
phpci.log

Comment 4 Shawn Iwinski 2013-02-04 20:10:16 UTC
One question before approval: How does the library itself (or the library user) know about the un-bundled library?

Comment 5 Remi Collet 2013-02-05 07:48:19 UTC
The user of this library will have to define a web alias.

AS the alias order is really important, all the needed alias will be defined in the main horde httpd configuration file (php-horde-horde is the main "framework" package for all the horde applications)

   # Link to system Javascript Libraries
   Alias /horde/js/scriptaculous     /usr/share/scriptaculous
   Alias /horde/js/prototype.js      /usr/share/prototype/prototype.js
   Alias /horde/js/ckeditor          /usr/share/ckeditor
   Alias /horde/js/syntaxhighlighter /usr/share/syntaxhighlighter

   # Link to horde
   Alias /horde                      /usr/share/horde


I agree, this is a bit ugly, but I really want to avoid "symlinks" solution which is even more ugly (and raise lot of update issue)

Comment 6 Shawn Iwinski 2013-02-05 11:12:48 UTC
Thanks for the explanation Remi.


No blockers.


===== APPROVED =====

Comment 7 Remi Collet 2013-02-05 11:26:30 UTC
Thanks for the review


New Package SCM Request
=======================
Package Name: php-horde-Horde-Editor
Short Description: Horde Editor API
Owners: remi nb
Branches: f18 el8
InitialCC:

Comment 8 Gwyn Ciesla 2013-02-05 13:51:45 UTC
Git done (by process-git-requests).

Corrected branch el8 to el6.

Comment 9 Remi Collet 2013-02-05 16:38:06 UTC
I will differ the import, as Horde_Serialize not yet approved

Comment 10 Fedora Update System 2013-02-16 10:06:34 UTC
php-horde-Horde-Editor-2.0.3-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Editor-2.0.3-2.fc18

Comment 11 Fedora Update System 2013-02-16 10:19:45 UTC
php-horde-Horde-Editor-2.0.3-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Editor-2.0.3-2.el6

Comment 12 Fedora Update System 2013-02-17 03:33:48 UTC
php-horde-Horde-Editor-2.0.3-2.fc18 has been pushed to the Fedora 18 testing repository.

Comment 13 Fedora Update System 2013-02-28 07:06:17 UTC
php-horde-Horde-Editor-2.0.3-2.fc18 has been pushed to the Fedora 18 stable repository.

Comment 14 Fedora Update System 2013-03-09 19:22:25 UTC
php-horde-Horde-Editor-2.0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository.


Note You need to log in before you can comment on or make changes to this bug.