Bug 785494 (Horde_Compress)
| Summary: | Review Request: php-horde-Horde-Compress - Horde Compression API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nick Bebout <nb> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, notting, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-03-29 01:38:35 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 785424, 785432, 785436, 785439, 785452 | ||||||||
| Bug Blocks: | 895622, 908329 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nick Bebout
2012-01-29 04:28:30 UTC
I am not an official package reviewer, but here are some comments I have for this package: *** It would help readability to group your Build* and Requires* statements together instead of mixing them with each other and your Provides and Conflicts statements *** Your BuildRequires should be BuildRequires: php-pear(PEAR) >= 1.7.0 instead of BuildRequires: php-pear >= 1:1.4.9-1.2 (this would match what you have in bug 785606 and satisfy this package's package.xml dependency) *** Your Provides statement should be Provides: php-pear(pear.horde.org/%{pear_name}) = %{version} instead of Provides: php-pear(%{pear_name}) = %{version} *** phpci results: For completeness (and to prevent any future packaging issues due to PHP package changes), you may wish to require the virtual provides "php-date", "php-pcre" and "php-zlib". *** All locale %files should be tagged with "%lang(xx)". rpmlint warnings: php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ar/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/bg/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/bs/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ca/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/cs/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/da/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/de/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/el/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/en/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/es/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/et/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/eu/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fa/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fi/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/fr/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/gl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/he/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/hr/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/hu/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/id/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/is/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/it/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ja/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/km/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ko/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/lt/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/lv/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/mk/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nb/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/nn/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pt/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/pt_BR/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ro/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/ru/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sk/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sl/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/sv/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/tr/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/uk/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/zh_CN/LC_MESSAGES/Horde_Compress.mo php-horde-Horde-Compress.noarch: W: file-not-in-%lang /usr/share/pear/data/Horde_Compress/locale/zh_TW/LC_MESSAGES/Horde_Compress.mo *** Do you plan on building for EPEL 5? - If not, please remove "rm -rf $RPM_BUILD_ROOT" from the %install section (see http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag). - If you do, there are several staements that need to be added. *** Up to you, but package.xml lists the optional package php-pear(pear.horde.org/Horde_Stream_Filter) if you choose to require (if you do choose to require this package, please update this ticket's "Depends On") I believe I have fixed those issues: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-1.0.7-1.fc16.src.rpm (In reply to comment #2) Almost ready for official review. Please change Requires: php-pear(pear.horde.org/Horde_Stream_Filter) to Requires: php-pear(pear.horde.org/Horde_Stream_Filter) < 2.0.0 per package.xml requirements (In reply to comment #3) Also, please add: Requires: php-common >= 5.2.0 I believe I have fixed those issues: Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-1.0.7-2.fc16.src.rpm I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package. Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-2.0.3-2.fc17.src.rpm Created attachment 695182 [details]
phpci.log
Created attachment 695183 [details]
php-horde-Horde-Compress-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 785494
[!]: Requires correct, justified where necessary. use php-common instead of php(language) for now except if you plan to differ EPEL-6 import until 6.4 release [!]: %check is present and all tests pass. I think I have send you, by mail, the correct script for %check which allow to run test (when locale used), even in mock. See : https://github.com/remicollet/remirepo/commit/fbcd7356809f945fb6c9e163cecd98bd68139b1c Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Compress-2.0.3-3.fc17.src.rpm [x]: %check is present and all tests pass. == APPROVED == New Package SCM Request ======================= Package Name: php-horde-Horde-Compress Short Description: An API for various compression techniques Owners: nb remi Branches: el6 f18 f19 InitialCC: Git done (by process-git-requests). php-horde-Horde-Compress-2.0.3-3.fc18,php-horde-Horde-Controller-2.0.1-3.fc18,php-horde-Horde-Mail-2.0.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Compress-2.0.3-3.fc18,php-horde-Horde-Controller-2.0.1-3.fc18,php-horde-Horde-Mail-2.0.4-1.fc18 php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6 Package php-horde-Horde-Mail-2.0.4-1.el6, php-horde-Horde-Template-2.0.1-3.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing php-horde-Horde-Mail-2.0.4-1.el6 php-horde-Horde-Template-2.0.1-3.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-0785/php-horde-Horde-Mail-2.0.4-1.el6,php-horde-Horde-Template-2.0.1-3.el6 then log in and leave karma (feedback). php-horde-Horde-Compress-2.0.3-3.fc18, php-horde-Horde-Controller-2.0.1-3.fc18, php-horde-Horde-Mail-2.0.4-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. php-horde-Horde-Mail-2.0.4-1.el6, php-horde-Horde-Template-2.0.1-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |