Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter-1.1.0-1.fc16.src.rpm Description: A collection of various stream filters.
I will review this package
After a quick review: [MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [MUST] "Requires: php-pear(PEAR) >= 1.7.0" to satisfy package.xml [SHOULD] %check is present and all tests pass [SHOULD] Localized php.ini not necessary (see https://bugzilla.redhat.com/show_bug.cgi?id=785471#c5)
Please update to 2.0.1
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter-2.0.1-2.fc17.src.rpm
Created attachment 693892 [details] phpci.log
Created attachment 693893 [details] php-horde-Horde-Stream-Filter-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785452
[!]: License field in the package spec file matches the actual license. LGPLv2 (not LGPLv2+) [!]: Package must own all directories that it creates. must own %{pear_phpdir}/Horde %{pear_phpdir}/Horde/Stream Just need to fix the License and dir ownership, else everything is ok. Can you please replace my "private" email by my fp.o one ?
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter-2.0.1-3.fc17.src.rpm
< License: LGPLv2+ --- > License: LGPLv2 [x]: License field in the package spec file matches the actual license. > %{pear_phpdir}/Horde > %{pear_phpdir}/Horde/Stream During build warning: File listed twice: /usr/share/pear/Horde/Stream warning: File listed twice: /usr/share/pear/Horde/Stream/Filter warning: File listed twice: /usr/share/pear/Horde/Stream/Filter warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Bin2hex.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Bin2hex.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Crc32.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Crc32.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Eol.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Eol.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Htmlspecialchars.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Htmlspecialchars.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Null.php warning: File listed twice: /usr/share/pear/Horde/Stream/Filter/Null.php Use %dir %{pear_phpdir}/Horde %dir %{pear_phpdir}/Horde/Stream %{pear_phpdir}/Horde/Stream/Filter or %{pear_phpdir}/Horde
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Stream-Filter-2.0.1-4.fc17.src.rpm
--- php-horde-Horde-Stream-Filter.spec.1 2013-02-06 22:09:46.000000000 +0100 +++ php-horde-Horde-Stream-Filter.spec 2013-03-20 21:06:31.000000000 +0100 @@ -5,7 +5,7 @@ Name: php-horde-Horde-Stream-Filter Version: 2.0.1 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Horde Stream filters Group: Development/Libraries @@ -78,13 +78,16 @@ %defattr(-,root,root,-) %doc %{pear_docdir}/%{pear_name} %{pear_xmldir}/%{name}.xml -%{pear_phpdir}/Horde -%{pear_phpdir}/Horde/Stream +%dir %{pear_phpdir}/Horde +%dir %{pear_phpdir}/Horde/Stream %{pear_phpdir}/Horde/Stream/Filter %{pear_testdir}/%{pear_name} %changelog +* Wed Mar 20 2013 Nick Bebout <nb> - 2.0.1-4 +- Update for review + * Wed Feb 6 2013 Nick Bebout <nb> - 2.0.1-3 - Update for review All issues fixed === APPROVED ===
New Package SCM Request ======================= Package Name: php-horde-Horde-Stream-Filter Short Description: A collection of various stream filters for Horde Owners: nb remi Branches: el6 f18 f19 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.el6,php-horde-Horde-LoginTasks-2.0.2-4.el6,php-horde-Horde-Stream-Filter-2.0.1-4.el6,php-horde-Horde-Token-2.0.3-3.el6
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Db-2.0.2-1.fc18,php-horde-Horde-Group-2.0.2-1.fc18,php-horde-Horde-LoginTasks-2.0.2-4.fc18,php-horde-Horde-Stream-Filter-2.0.1-4.fc18,php-horde-Horde-Token-2.0.3-3.fc18
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-horde-Horde-Db-2.0.2-1.fc18, php-horde-Horde-Group-2.0.2-1.fc18, php-horde-Horde-LoginTasks-2.0.2-4.fc18, php-horde-Horde-Stream-Filter-2.0.1-4.fc18, php-horde-Horde-Token-2.0.3-3.fc18 has been pushed to the Fedora 18 stable repository.
php-horde-Horde-Db-2.0.2-1.el6, php-horde-Horde-LoginTasks-2.0.2-4.el6, php-horde-Horde-Stream-Filter-2.0.1-4.el6, php-horde-Horde-Token-2.0.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository.