Bug 78620
Summary: | deleting a user fails to remove the default group entry that is added by default | ||
---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | Michael Lee Yohe <michael> |
Component: | redhat-config-users | Assignee: | Brent Fox <bfox> |
Status: | CLOSED RAWHIDE | QA Contact: | |
Severity: | low | Docs Contact: | |
Priority: | medium | ||
Version: | 8.0 | CC: | jpenix, mitr |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | i686 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2003-05-25 14:30:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michael Lee Yohe
2002-11-26 16:08:52 UTC
*** This bug has been marked as a duplicate of 78619 *** Well, I can't delete the group automatically because it may have other users in it, and it would be wrong to delete a group that other users belong to. So here's what I did. When you select a user to delete, we look at that user's primary group. If that user is the only member of that group, we pop up a dialog offering to delete the group as well. The user can say yes or no. If there are group members other than the one selected for deletion, we do not show the dialog to delete the group. I think this is a reasonable way to solve it. Can you think of anything wrong with this? If so, please reopen this bug. If not, please test with redhat-config-users-1.1.1-9 in Rawhide (should appear tomorrow morning). QA, please verify. dialog verified in redhat-config-users-1.1.2-2. verified that groups are deleted/remain as appropriate verified that dialog does not appear when group is not private *However note that when group is not private the remove home directory dialog is also skipped. I propose this feature be merged with the other user delete options. Please see bug#69712 Actually, I've changed this behavior again. If the user's primary group has only one user in it, we will delete the group automatically. This makes sense because the user will almost always want to delete the group associated with that user. If they recreate the user, the group will also be recreated. Please test with redhat-config-users-1.1.3-3. This change breaks the tool in the following scenario: 1) Create a user and opt not to create a group for the user (the user will be assigned to the group 'users'). 2) Delete the user that you have just created. Since this user is the only member of the group users, that group is deleted. 3) Now try to create another user without creating a group (as in step 1). The dialog window locks up with the waiting cursor and a traceback appears on standard error. In general this practice of autodeleting the group is not right, what if user_a happens to be the only member of an important system group like floppy or disk? At the very least, you need to exclude groups <500, and possibly only do the autodelete thing when the name_of_group=name_of_user (or both restrictions). Better yet, implement my suggestion from bug#69712. Here is the traceback I mentioned. Traceback (most recent call last): File "/usr/share/redhat-config-users/userWindow.py", line 315, in on_userWin_ok_button_clicked self.addToUsersGroup(userEnt, userName) File "/usr/share/redhat-config-users/userWindow.py", line 332, in addToUsersGroup cn = groupEnt.get(libuser.GROUPNAME)[0] AttributeError: 'NoneType' object has no attribute 'get' Ok, should be fixed in 1.1.5-8. It will no longer automatically delete groups with gid < 500. Built in dist-10 There is a stack of 64 bugs that have been in Modified state for a long period of time. I am closing these as Rawhide now. If you find that the issue is not fixed, please reopen this report. |