Bug 836142

Summary: Shortcuts for highlighting text is instead inserting TM result (Alt+Shift+keypad conflict) [1.7]
Product: [Retired] Zanata Reporter: Ding-Yi Chen <dchen>
Component: Component-UIAssignee: Alex Eng <aeng>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: high Docs Contact:
Priority: unspecified    
Version: 1.6CC: aeng, hpeters, sflaniga, zanata-bugs
Target Milestone: ---   
Target Release: 1.7   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: 1.7-SNAPSHOT (20120705-0026) Doc Type: Bug Fix
Doc Text:
Cause: Conflicting keyboard keys between text selecting in editor and copy from translation memory into editor. Consequence: Users can't use Ctrl+Shift + left arrow key to select text in editor. Fix: See https://bugzilla.redhat.com/show_bug.cgi?id=836051#c2
Story Points: ---
Clone Of: 834979 Environment:
Last Closed: 2012-09-11 05:11:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ding-Yi Chen 2012-06-28 08:18:17 UTC
+++ This bug was initially created as a clone of Bug #834979 +++

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:9.0.1) Gecko/20100101 Firefox/9.0.1
Build Identifier: 

Using standard keyboard combinations for highlighting text is instead inserting a TM result. 

Reproducible: Always

Steps to Reproduce:
1. Open existing translation in editor, putting the cursor at the end of the string.
2. Hold down Ctrl+Shift, then additionally press left arrow key.

Actual Results:  
The 4th TM match is being inserted into the editor. 

Expected Results:  
Holding down Ctrl+Shift, with each time I hit the left arrow key, he text should be highlighted word by word  -- this is standard text editor behaviour.

Severity medium/high because this behaviour is really unexpected, deletes existing translation inserting and approving a different translation, and there is no undo functionality any more to fix what happened.

--- Additional comment from aeng on 2012-06-26 09:54:20 EST ---

Suggest copy from TM shortcut to be change from ALT+SHIFT + 1,2,3,4 to 
CTRL+ATL + 1,2,3,4 to prevent conflict of keypad 4 with left arrow button as result of Shift key being press.

--- Additional comment from aeng on 2012-06-26 13:18:40 EST ---

Fixed in 1.6.1

See https://github.com/zanata/zanata/commit/ffec30c5c88f3ebfc2e2b4366a648ab426b0d764

--- Additional comment from dchen on 2012-06-28 18:17:24 EST ---

VERIFIED with Zanata version 1.6.1-SNAPSHOT (20120628-0014)

But problem remains with Zanata version 1.7-SNAPSHOT (20120626-0025)

Comment 1 Hedda Peters 2012-06-29 03:34:13 UTC
Turns out my original bug report (https://bugzilla.redhat.com/show_bug.cgi?id=834979) should have been against the 1.7 version, THAT'S where I've noticed the problem. Sorry for any confusion.

Any hope to have this fixed and deployed for 1.7.x soon? 

I've stalled my current translation assignments because it's too painful working with this bug.

Comment 2 Sean Flanigan 2012-06-29 03:51:04 UTC
Um, 1.7.0 hasn't been released yet.

Comment 3 Hedda Peters 2012-06-29 03:53:57 UTC
Oh gosh... of course, sorry. I'm getting ahead of myself here.

Nevermind, and thank god it's friday. :-D

Comment 4 Alex Eng 2012-07-03 22:37:40 UTC
Issue fixed in 1.7 along with fixes from
https://bugzilla.redhat.com/show_bug.cgi?id=836051#c2

Comment 5 Ding-Yi Chen 2012-07-05 03:22:58 UTC
VERIFIED with 1.7-SNAPSHOT (20120705-0026)