Bug 854959
| Summary: | Exception handling in Anaconda doesn't work if dump contains non-ascii characters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vratislav Podzimek <vpodzime> |
| Component: | python-meh | Assignee: | Vratislav Podzimek <vpodzime> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 18 | CC: | awilliam, g.kaviyarasu, jonathan, knight, kparal, lmacken, piotrdrag, robatino, tflink, vanmeeuwen+fedora, vpodzime, w_pirker |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | AcceptedNTH RejectedBlocker | ||
| Fixed In Version: | python-meh-0.17-1.fc18 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 854688 | Environment: | |
| Last Closed: | 2012-11-01 20:31:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 752664 | ||
|
Description
Vratislav Podzimek
2012-09-06 11:49:18 UTC
As the following traceback shows:
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/pyanaconda/exception.py", line 59, in run_handleException_on_idle
obj)
File "/usr/lib/python2.7/site-packages/meh/handler.py", line 101, in handleException
fd.write(self.exnText)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xfd' in position 1059: ordinal not in range(128)
exception handling (and thus bug reporting) in Anaconda fails, if exception dump info contains non-ascii characters. I'm proposing this as a F18Alpha blocker, per this criteria:
> The installer must be able to report failures to Bugzilla and local disk, with appropriate information included
Patch has been sent to anaconda-patches-list.
Discussed at the 2012-09-06 Fedora 18 alpha go/no-go meeting. Rejected as a blocker for F18 alpha but accepted as NTH. While it is aconditional violation of the following F18 alpha release criterion: The installer must be able to report failures to Bugzilla and local disk, with appropriate information included. this only happens for non-ascii strings which doesn't seem to be easy enough to hit to warrant blocker status. python-meh-0.16-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-meh-0.16-1.fc18 Vratislav, can you please add a reproducer how to make sure this is fixed? The Czech language bug in the initial screen was already fixed by a different patch, so I don't know how to test this. I at least tried to boot Alpha RC2 Live, update python-meh and perform installation. Everything worked OK, so there hopefully isn't any serious regression. Package python-meh-0.16-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-meh-0.16-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-13802/python-meh-0.16-1.fc18 then log in and leave karma (feedback). (In reply to comment #4) > Vratislav, can you please add a reproducer how to make sure this is fixed? > The Czech language bug in the initial screen was already fixed by a > different patch, so I don't know how to test this. You can download and install python-meh-0.16-1 RPM from [1], install it and run simple testing script [2] [1] http://koji.fedoraproject.org/koji/buildinfo?buildID=353634 [2] http://vpodzime.fedorapeople.org/meh_test.py If I run the script with the updated package, I receive anaconda-style error window "Unknown error has occured". Is that correct? (In reply to comment #8) > If I run the script with the updated package, I receive anaconda-style error > window "Unknown error has occured". Is that correct? Yes, this means, it has successfully over the problematic part of dumping non-ascii characters. Verified then. python-meh-0.16-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. Unfortunately, it appears, that there are cases where changes made in python-meh-0.16-1 don't work. Reopening this bug. *** Bug 859163 has been marked as a duplicate of this bug. *** The original patch fixed the case when there was some unicode string (with Python's unicode type), but didn't fix the case when there was unicode string encoded and stored as common string. New patch posted to anaconda-patches list. Discussed at 2012-09-26 blocker review meeting: http://meetbot.fedoraproject.org/fedora-qa/2012-09-26/f18-beta-blocker-review-1.2012-09-26-16.03.log.txt . Especially since this is partly fixed already, we think it's still not significant enough to make blocker status even for Beta, but we accept it as NTH. (it's a partial violation of the "The installer must be able to report failures to Bugzilla and local disk, with appropriate information included" criterion, but we don't think the infringing cases are significant enough to qualify). vratislav, has the fix made its way into 18.9? (In reply to comment #15) > Discussed at 2012-09-26 blocker review meeting: > http://meetbot.fedoraproject.org/fedora-qa/2012-09-26/f18-beta-blocker- > review-1.2012-09-26-16.03.log.txt . Especially since this is partly fixed > already, we think it's still not significant enough to make blocker status > even for Beta, but we accept it as NTH. (it's a partial violation of the > "The installer must be able to report failures to Bugzilla and local disk, > with appropriate information included" criterion, but we don't think the > infringing cases are significant enough to qualify). > > vratislav, has the fix made its way into 18.9? Unfortunately not, it still hangs on the anaconda-patches. I'll try to urge somebody from the team to do the review. python-meh-0.17-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-meh-0.17-1.fc18 Package python-meh-0.17-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing python-meh-0.17-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-15784/python-meh-0.17-1.fc18 then log in and leave karma (feedback). Updated script for testing available at: http://vpodzime.fedorapeople.org/meh_test.py If everything goes well, python-meh's "An unexpected error..." window appears and the text entry contains correct object dump with all non-ascii characters in both unicode_str and encoded_unicode_str (In reply to comment #19) > Updated script for testing available at: > http://vpodzime.fedorapeople.org/meh_test.py > > If everything goes well, python-meh's "An unexpected error..." window > appears and the text entry contains correct object dump with all non-ascii > characters in both unicode_str and encoded_unicode_str Yup, that works. *** Bug 868373 has been marked as a duplicate of this bug. *** Update was pushed stable, closing. *** Bug 872599 has been marked as a duplicate of this bug. *** |