Bug 894570 (Horde_Editor)
| Summary: | Review Request: php-horde-Horde-Editor - Horde Editor API | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | nb, notting, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-02-28 07:06:14 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 785436, 785449, 785476, 873408 | ||||||||
| Bug Blocks: | 908329 | ||||||||
| Attachments: |
|
||||||||
|
Description
Remi Collet
2013-01-12 09:05:05 UTC
New version Spec: https://raw.github.com/remicollet/remirepo/3a8226fa9198aa2b54d16236c08f599598c8e037/php/horde/php-horde-Horde-Editor/php-horde-Horde-Editor.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Editor-2.0.2-1.remi.src.rpm Created attachment 692994 [details]
php-horde-Horde-Editor-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 894570 --mock-config fedora-rawhide-x86_64
Created attachment 692995 [details]
phpci.log
One question before approval: How does the library itself (or the library user) know about the un-bundled library? The user of this library will have to define a web alias. AS the alias order is really important, all the needed alias will be defined in the main horde httpd configuration file (php-horde-horde is the main "framework" package for all the horde applications) # Link to system Javascript Libraries Alias /horde/js/scriptaculous /usr/share/scriptaculous Alias /horde/js/prototype.js /usr/share/prototype/prototype.js Alias /horde/js/ckeditor /usr/share/ckeditor Alias /horde/js/syntaxhighlighter /usr/share/syntaxhighlighter # Link to horde Alias /horde /usr/share/horde I agree, this is a bit ugly, but I really want to avoid "symlinks" solution which is even more ugly (and raise lot of update issue) Thanks for the explanation Remi. No blockers. ===== APPROVED ===== Thanks for the review New Package SCM Request ======================= Package Name: php-horde-Horde-Editor Short Description: Horde Editor API Owners: remi nb Branches: f18 el8 InitialCC: Git done (by process-git-requests). Corrected branch el8 to el6. I will differ the import, as Horde_Serialize not yet approved php-horde-Horde-Editor-2.0.3-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Editor-2.0.3-2.fc18 php-horde-Horde-Editor-2.0.3-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Editor-2.0.3-2.el6 php-horde-Horde-Editor-2.0.3-2.fc18 has been pushed to the Fedora 18 testing repository. php-horde-Horde-Editor-2.0.3-2.fc18 has been pushed to the Fedora 18 stable repository. php-horde-Horde-Editor-2.0.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |