Bug 979570

Summary: bridge: rollback network setup in case of failure
Product: [oVirt] ovirt-host-deploy Reporter: Alon Bar-Lev <alonbl>
Component: Plugins.VDSMAssignee: Alon Bar-Lev <alonbl>
Status: CLOSED CURRENTRELEASE QA Contact: Martin Pavlik <mpavlik>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: ---CC: acathrow, bazulay, bugs, dougsland, gklein, iheim, jkt, lpeer, myakove, Rhev-m-bugs
Target Milestone: ---Keywords: Improvement
Target Release: 1.1.0Flags: lpeer: devel_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: is7 Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-21 22:19:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 979081, 979567, 979572, 999123    
Bug Blocks:    

Description Alon Bar-Lev 2013-06-28 20:14:52 UTC 
Continue discussion from bug#979081.

Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.

The sequence should be:
- addNetwork
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit

vdsm-restore-net-config does not work on ovirt-node/rhev-h, waiting for bug#979567.

Supporting non-node setup is not important to 3.3 as only legacy nodes still use the ovirt-host-deploy bridge plugin.

Best if we could avoid the bridge module anyway and perform all from engine, including the removal of brXXX bridges, so we do not need to maintain these deviations.
Comment 1 Martin Pavlik 2013-07-30 08:18:04 UTC 
How to test:

add raise RuntimeException('XXX') anywhere after bridge is created... best plugins/ovirt-host-deploy/vdsm/bridge.py at end of _misc

RHEVM 3.3 with 3.3 host and "fixed" bridge.py in the engine , add network will fail and vdsm-restore-net-config will restore previous state

need separate testing for RHEVH when bug 979081 is ON_QA
Comment 2 Martin Pavlik 2013-07-30 10:22:39 UTC 
in IS7 procedure described in comment 1 works as expected, waiting for bug 97908 to be ON_QA in order to finish testing this one
Comment 3 Martin Pavlik 2013-07-30 10:24:02 UTC 
correction of comment 2 waiting for bug 979081 to be fixed
Comment 4 Martin Pavlik 2013-09-03 08:41:49 UTC 
verified
Comment 5 Itamar Heim 2014-01-21 22:19:23 UTC 
Closing - RHEV 3.3 Released
Comment 6 Itamar Heim 2014-01-21 22:25:33 UTC 
Closing - RHEV 3.3 Released