Red Hat Bugzilla – Bug 979570
bridge: rollback network setup in case of failure
Last modified: 2016-02-10 14:46:35 EST
Continue discussion from bug#979081.
Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.
The sequence should be:
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit
vdsm-restore-net-config does not work on ovirt-node/rhev-h, waiting for bug#979567.
Supporting non-node setup is not important to 3.3 as only legacy nodes still use the ovirt-host-deploy bridge plugin.
Best if we could avoid the bridge module anyway and perform all from engine, including the removal of brXXX bridges, so we do not need to maintain these deviations.
How to test:
add raise RuntimeException('XXX') anywhere after bridge is created... best plugins/ovirt-host-deploy/vdsm/bridge.py at end of _misc
RHEVM 3.3 with 3.3 host and "fixed" bridge.py in the engine , add network will fail and vdsm-restore-net-config will restore previous state
need separate testing for RHEVH when bug 979081 is ON_QA
in IS7 procedure described in comment 1 works as expected, waiting for bug 97908 to be ON_QA in order to finish testing this one
correction of comment 2 waiting for bug 979081 to be fixed
Closing - RHEV 3.3 Released