Bug 979570 - bridge: rollback network setup in case of failure
Summary: bridge: rollback network setup in case of failure
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-host-deploy
Classification: oVirt
Component: Plugins.VDSM
Version: ---
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: 1.1.0
Assignee: Alon Bar-Lev
QA Contact: Martin Pavlik
URL:
Whiteboard: network
Depends On: 979081 979567 979572 999123
Blocks:
TreeView+ depends on / blocked
 
Reported: 2013-06-28 20:14 UTC by Alon Bar-Lev
Modified: 2016-02-10 19:46 UTC (History)
10 users (show)

Fixed In Version: is7
Clone Of:
Environment:
Last Closed: 2014-01-21 22:19:23 UTC
oVirt Team: Network
Embargoed:
lpeer: devel_ack+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 17124 0 None None None Never

Description Alon Bar-Lev 2013-06-28 20:14:52 UTC 
Continue discussion from bug#979081.

Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.

The sequence should be:
- addNetwork
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit

vdsm-restore-net-config does not work on ovirt-node/rhev-h, waiting for bug#979567.

Supporting non-node setup is not important to 3.3 as only legacy nodes still use the ovirt-host-deploy bridge plugin.

Best if we could avoid the bridge module anyway and perform all from engine, including the removal of brXXX bridges, so we do not need to maintain these deviations.
Comment 1 Martin Pavlik 2013-07-30 08:18:04 UTC 
How to test:

add raise RuntimeException('XXX') anywhere after bridge is created... best plugins/ovirt-host-deploy/vdsm/bridge.py at end of _misc

RHEVM 3.3 with 3.3 host and "fixed" bridge.py in the engine , add network will fail and vdsm-restore-net-config will restore previous state

need separate testing for RHEVH when bug 979081 is ON_QA
Comment 2 Martin Pavlik 2013-07-30 10:22:39 UTC 
in IS7 procedure described in comment 1 works as expected, waiting for bug 97908 to be ON_QA in order to finish testing this one
Comment 3 Martin Pavlik 2013-07-30 10:24:02 UTC 
correction of comment 2 waiting for bug 979081 to be fixed
Comment 4 Martin Pavlik 2013-09-03 08:41:49 UTC 
verified
Comment 5 Itamar Heim 2014-01-21 22:19:23 UTC 
Closing - RHEV 3.3 Released
Comment 6 Itamar Heim 2014-01-21 22:25:33 UTC 
Closing - RHEV 3.3 Released
Note You need to log in before you can comment on or make changes to this bug.