Bug 979567 - vdsm-restore-net-config - add --force parameter
Summary: vdsm-restore-net-config - add --force parameter
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: vdsm
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Martin Pavlik
URL:
Whiteboard: network
Depends On:
Blocks: 979081 979570 979572 999123
TreeView+ depends on / blocked
 
Reported: 2013-06-28 20:09 UTC by Alon Bar-Lev
Modified: 2016-02-10 19:57 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-07-03 09:10:48 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Alon Bar-Lev 2013-06-28 20:09:53 UTC 
Continue discussion from bug#979081.

Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.

The sequence should be:
- addNetwork
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit

The problem is that vdsm-restore-net-config does not work on ovirt-node/rhev-h as it supposed to run at boot time while node does not persist the configuration if commit was not called.

First question... why does it bad to run rollbak it in boot time? worse case it will not find anything to rollback...

What I recommend is adding --force parameter to vdsm-restore-net-config to allow using it during host-deploy and support rollback at any environment.
Comment 1 Dan Kenigsberg 2013-07-03 09:10:48 UTC 
I'd rather make the --force semantics implicit, as described in https://bugzilla.redhat.com/show_bug.cgi?id=979081#c8
Note You need to log in before you can comment on or make changes to this bug.