Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 979567

Summary: vdsm-restore-net-config - add --force parameter
Product: Red Hat Enterprise Virtualization Manager Reporter: Alon Bar-Lev <alonbl>
Component: vdsmAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Martin Pavlik <mpavlik>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: asegurap, bazulay, danken, gklein, hateya, iheim, lpeer, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-07-03 09:10:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 979081, 979570, 979572, 999123    

Description Alon Bar-Lev 2013-06-28 20:09:53 UTC 
Continue discussion from bug#979081.

Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.

The sequence should be:
- addNetwork
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit

The problem is that vdsm-restore-net-config does not work on ovirt-node/rhev-h as it supposed to run at boot time while node does not persist the configuration if commit was not called.

First question... why does it bad to run rollbak it in boot time? worse case it will not find anything to rollback...

What I recommend is adding --force parameter to vdsm-restore-net-config to allow using it during host-deploy and support rollback at any environment.
Comment 1 Dan Kenigsberg 2013-07-03 09:10:48 UTC 
I'd rather make the --force semantics implicit, as described in https://bugzilla.redhat.com/show_bug.cgi?id=979081#c8