Red Hat Bugzilla – Bug 979572
vdsm-reg: rollback network configuration if addNetwork fails
Last modified: 2016-02-10 15:00:05 EST
Continue discussion from bug#979081.
Currently vdsm-bootstrap, host-deploy, vdsm-reg do not rollback network configuration if addNetwork fails.
The sequence should be:
- vdsm-restore-net-config -> rollback
- vdsm-store-net-config -> commit
vdsm-restore-net-config does not work on ovirt-node/rhev-h, waiting for bug#979567.
Best if we could avoid the bridge module anyway and perform all from engine, including the removal of brXXX bridges, so we do not need to maintain these deviations.
When is vdsm-reg's makeBridge code used these days? I thought it has been deprecated by ovirt-host-deploy.
If this corner case does not affect the master branch, and lacking customers complaining about this, I would rather not touch the vdsm-reg hornet nest.
(In reply to Dan Kenigsberg from comment #1)
> When is vdsm-reg's makeBridge code used these days? I thought it has been
> deprecated by ovirt-host-deploy.
vdsm-reg is not deprecated, it should have been replaced by bug#875088, so the logic is intact... as the unfortunate design creates the bridge before it tries to register.
> If this corner case does not affect the master branch, and lacking customers
> complaining about this, I would rather not touch the vdsm-reg hornet nest.
I agree, I opened this bug to get formal approval.
In this case, I suggest not to solve it. If this becomes urgently needed, and we end up touching vdsm-reg, I prefer to drop bridge creation from it, and let it be solved once in ovirt-host-deploy.
*** Bug 979081 has been marked as a duplicate of this bug. ***